[Bug 212111] ng_btsocket(4) lacks info on updated struct sockaddr_l2cap layout

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Bug 212111] ng_btsocket(4) lacks info on updated struct sockaddr_l2cap layout

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212111

            Bug ID: 212111
           Summary: ng_btsocket(4) lacks info on updated struct
                    sockaddr_l2cap layout
           Product: Documentation
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Documentation
          Assignee: [hidden email]
          Reporter: [hidden email]

/usr/include/netgraph/bluetooth/include/ng_btsocket.h from 11.0:

struct sockaddr_l2cap {
    u_char      l2cap_len;  /* total length */
    u_char      l2cap_family;   /* address family */
    u_int16_t   l2cap_psm;  /* PSM (Protocol/Service Multiplexor) */
    bdaddr_t    l2cap_bdaddr;   /* address */
    u_int16_t   l2cap_cid;      /*cid*/
    u_int8_t    l2cap_bdaddr_type; /*address type*/
};

Last two fields were added in r281198 by takawata@:

https://svnweb.freebsd.org/base/head/sys/netgraph/bluetooth/include/ng_btsocket.h?r1=180399&r2=281198

with warning telling to check new fields for being initialized.

the same struct description from ng_btsocket(4):

struct sockaddr_l2cap {
    u_char    l2cap_len;    /* total length */
    u_char    l2cap_family; /* address family */
    uint16_t  l2cap_psm;    /* Protocol/Service Multiplexor */
    bdaddr_t  l2cap_bdaddr; /* address */
};

1) The manpage should be updated
2) The new fields should be documented

The latter is crucial for fixing numerous ports which have problems on 11.x
(some fail to build because of warning and -Werror, others may fail in runtime
because improperly initialized fields)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-doc
To unsubscribe, send any mail to "[hidden email]"