[Bug 228265] audio/fluidsynth: Update to 1.1.11

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 228265] audio/fluidsynth: Update to 1.1.11

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228265

            Bug ID: 228265
           Summary: audio/fluidsynth: Update to 1.1.11
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
             Flags: maintainer-feedback?([hidden email])
          Assignee: [hidden email]

Created attachment 193413
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193413&action=edit
fluidsynth-1.1.11.patch

Change
  LICENSE LGPL20+ -> LGPL21
  MASTER_SITES SOURCEFORGE -> GitHub

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 228265] audio/fluidsynth: Update to 1.1.11

bugzilla-noreply
Bugzilla Automation <[hidden email]> has asked freebsd-multimedia mailing
list <[hidden email]> for maintainer-feedback:
Bug 228265: audio/fluidsynth: Update to 1.1.11
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228265



--- Description ---
Change
  LICENSE LGPL20+ -> LGPL21
  MASTER_SITES SOURCEFORGE -> GitHub
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 228265] audio/fluidsynth: Update to 1.1.11

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228265

--- Comment #1 from Mathieu Arnold <[hidden email]> ---
Many parts in here are not where they belong. Can you please read [[
https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html |
Chapter 15. Order of Variables in Port Makefiles ]] and correct your patch?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 228265] audio/fluidsynth: Update to 1.1.11

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228265

--- Comment #2 from Mathieu Arnold <[hidden email]> ---
Also, please don't set GH_TAGNAME, use DISTVERSIONPREFIX.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 228265] audio/fluidsynth: Update to 1.1.11

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228265

Tobias Kortkamp <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Tobias Kortkamp <[hidden email]> ---
This completely breaks sndio support.  This change to patch-CMakeLists.txt
is wrong:

++    unset ( SNDIO_SUPPORT CACHE )
++    if ( enable-sndio )
++    pkg_check_modules ( SNDIO libsndio>=1.4.0 )
++    set ( SNDIO_SUPPORT ${SNDIO_FOUND} )
++    else ( enable-sndio )
++    unset_pkg_config ( SNDIO )
++    endif ( enable-sndio )

sndio doesn't come with a pkg-config file, so I'm not sure why this was
changed to use pkg_check_modules.  Please keep it like before.  This bit

-+unset ( SNDIO_SUPPORT CACHE )
-+if ( enable-sndio )
-+  set ( SNDIO_SUPPORT 1 )
-+endif ( enable-sndio )

needs to stay like it was.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 228265] audio/fluidsynth: Update to 1.1.11

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228265

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193413|0                           |1
        is obsolete|                            |

--- Comment #4 from [hidden email] ---
Created attachment 193417
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193417&action=edit
fluidsynth-1.1.11.patch

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 228265] audio/fluidsynth: Update to 1.1.11

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228265

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193417|0                           |1
        is obsolete|                            |

--- Comment #5 from [hidden email] ---
Created attachment 193418
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193418&action=edit
fluidsynth-1.1.11.patch

portlint(1) was not running.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-multimedia
To unsubscribe, send any mail to "[hidden email]"