[Bug 229348] [exp-run] Remove GPL'd libssp from libc

classic Classic list List threaded Threaded
13 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

            Bug ID: 229348
           Summary: [exp-run] Remove GPL'd libssp from libc
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email]

Created attachment 194651
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194651&action=edit
Patch to define libssp as part of gcclibs

GCC includes libssp which we have historically linked into our libc(!),

It appears this library is not really needed as it is meant to support
FORTIFY_SOURCE but we never brought any way to link the wrapper functions.

As discussed in https://reviews.freebsd.org/D15687, we should get away by
building along with the other gcclibs only when GCC is built.

Buildworld passes on current, but If you can please try a clean build with this
patch we should confirm if some port is trying to link anything from there.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://reviews.freebsd.org
                   |                            |/D15687

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

--- Comment #1 from Antoine Brodin <[hidden email]> ---
We can't build any port with the provided patch.


checking whether the C compiler works... no
configure: error: in `/wrkdirs/usr/ports/ports-mgmt/pkg/work/pkg-1.10.5':
configure: error: C compiler cannot create executables

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

--- Comment #2 from Antoine Brodin <[hidden email]> ---
From config.log:

configure:3586: checking whether the C compiler works
configure:3608: cc -O2 -pipe  -Wno-error -fstack-protector -fno-strict-aliasing
  -fstack-protector conftest.c  >&5
/usr/bin/ld: error: cannot open /usr/lib/libssp_nonshared.a: No such file or
directory
cc: error: linker command failed with exit code 1 (use -v to see invocation)

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Closed
         Resolution|---                         |Overcome By Events

--- Comment #3 from Pedro F. Giffuni <[hidden email]> ---
Thanks it was good to know what is failing but I abandoned the revision, at
least for now.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194651|0                           |1
        is obsolete|                            |

--- Comment #4 from Pedro F. Giffuni <[hidden email]> ---
Created attachment 195162
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195162&action=edit
Define libssp as part of gcclibs and don't include libssp in libc

Looking at this further, libssp_nonshared shouldn't be in libc at all.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|Overcome By Events          |---
             Status|Closed                      |Open

--- Comment #5 from Pedro F. Giffuni <[hidden email]> ---
Re-open: can you kindly test this new patch?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |Overcome By Events
             Status|Open                        |Closed

--- Comment #6 from Pedro F. Giffuni <[hidden email]> ---
(In reply to Pedro F. Giffuni from comment #5)
Nevermind .. I am having build issues.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #195162|0                           |1
        is obsolete|                            |

--- Comment #7 from Pedro F. Giffuni <[hidden email]> ---
Created attachment 206258
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206258&action=edit
Fix by adjusting libc.ldscript to not link libssp

libc was bogusly linking libgcc_noshared when we were expecting simply to drop
it.

The issue seems to be in libc.ldscript.

This patch works for all platforms except powerpc but jhibbits has confirmed
the issue will go away once powerpc is moved to clang.

An exp-run should work OK now.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Closed                      |Open
         Resolution|Overcome By Events          |---

--- Comment #8 from Pedro F. Giffuni <[hidden email]> ---
New patch: should work on all platforms, except powerpc temporarily.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

--- Comment #9 from Antoine Brodin <[hidden email]> ---
Exp-run is still not good,  for instance

checking whether the C compiler works... no
configure: error: in
`/wrkdirs/usr/ports/net-mgmt/net-snmp/work/net-snmp-5.7.3':
configure: error: C compiler cannot create executables

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |In Progress

--- Comment #10 from Pedro F. Giffuni <[hidden email]> ---
(In reply to Antoine Brodin from comment #9)
Thanks (back to drawing board)

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229348] [exp-run] Remove GPL'd libssp from libc

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229348

Pedro F. Giffuni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |228919


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228919
[Bug 228919] GCC 4.2.1 removal
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"