[Bug 229404] [pflog] [patch] pflogs kernel modules build fails with VIMAGE

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [patch] pflogs kernel modules build fails with VIMAGE

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

            Bug ID: 229404
           Summary: [pflog] [patch] pflogs kernel modules build fails with
                    VIMAGE
           Product: Base System
           Version: 11.2-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: easy, patch-ready
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: [hidden email]
          Reporter: [hidden email]

Created attachment 194720
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194720&action=edit
add opt_global.h

pflog's module Makefile fails to include opt_global.h to SRCS leading to build
error for VIMAGE case. Trivial patch fixing this is attached.

cc -O2 -pipe -include opt_global.h -march=core2  -fno-strict-aliasing -Werror
-D_KERNEL -DKLD_MODULE -nostdinc   -I. -I/data2/src/sys -fno-common
-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer   -MD
-MF.depend.if_pflog.o -MTif_pflog.o -mcmodel=kernel -mno-red-zone -mno-mmx
-mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv
-fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs
-fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare
-Wno-error-empty-body -Wno-error-parentheses-equality
-Wno-error-unused-function -Wno-error-pointer-sign
-Wno-error-shift-negative-value -Wno-error-address-of-packed-member  -mno-aes
-mno-avx  -std=iso9899:1999 -c /data2/src/sys/netpfil/pf/if_pflog.c -o
if_pflog.o
<built-in>:1:10: fatal error: 'opt_global.h' file not found
#include "opt_global.h"
         ^~~~~~~~~~~~~~
1 error generated.
*** Error code 1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [patch] pflogs kernel modules build fails with VIMAGE

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

Eugene Grosbein <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #194720|0                           |1
        is obsolete|                            |

--- Comment #1 from Eugene Grosbein <[hidden email]> ---
Created attachment 194721
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=194721&action=edit
add opt_global.h

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

Eugene Grosbein <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Summary|[pflog] [patch] pflogs      |[pflog] [pfsync] [patch]
                   |kernel modules build fails  |pflogs/pfsync kernel
                   |with VIMAGE                 |modules build fails with
                   |                            |VIMAGE

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

Kristof Provost <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #2 from Kristof Provost <[hidden email]> ---
How are you building? For what platform?

VIMAGE is enabled in GENERIC (at least for some platforms), so I'm not sure why
you're seeing this and I'm not.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

--- Comment #3 from Eugene Grosbein <[hidden email]> ---
(In reply to Kristof Provost from comment #2)

I build kernel module outside of kernel build environment while having enabled
VIMAGE= in /etc/src.conf, FreeBSD 11.2-STABLE/amd64, or this way:

cd /usr/src/sys/modules/pflog && make VIMAGE=yes

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

--- Comment #4 from [hidden email] ---
A commit references this bug:

Author: kp
Date: Sun Jul  1 18:09:17 UTC 2018
New revision: 335847
URL: https://svnweb.freebsd.org/changeset/base/335847

Log:
  pflog/pfsync: Fix module build with VIMAGE=yes

  pflog and pfsync's module Makefile fails to include opt_global.h to SRCS
  leading to build error for VIMAGE case.

  Reproduced with:
  cd /usr/src/sys/modules/pflog && make VIMAGE=yes

  PR:           229404
  Submitted by: eugen@
  MFC after:    1 week

Changes:
  head/sys/modules/pflog/Makefile
  head/sys/modules/pfsync/Makefile

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

Kristof Provost <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]              |[hidden email]
             Status|New                         |In Progress

--- Comment #5 from Kristof Provost <[hidden email]> ---
Thanks for the patch.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

Rodney W. Grimes <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

--- Comment #6 from [hidden email] ---
A commit references this bug:

Author: kp
Date: Sun Jul  8 10:54:12 UTC 2018
New revision: 336087
URL: https://svnweb.freebsd.org/changeset/base/336087

Log:
  pflog/pfsync: Fix module build with VIMAGE=yes

  pflog and pfsync's module Makefile fails to include opt_global.h to SRCS
  leading to build error for VIMAGE case.

  Reproduced with:
  cd /usr/src/sys/modules/pflog && make VIMAGE=yes

  PR:           229404
  Submitted by: eugen@

Changes:
_U  stable/11/
  stable/11/sys/modules/pflog/Makefile
  stable/11/sys/modules/pfsync/Makefile

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

Kristof Provost <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|In Progress                 |Closed

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 229404] [pflog] [pfsync] [patch] pflogs/pfsync kernel modules build fails with VIMAGE

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229404

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |mfc-stable11+
           Keywords|patch-ready                 |

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-pf
To unsubscribe, send any mail to "[hidden email]"