[Bug 231110] GTK print dialogs falsely believe lpr cannot accept PDF

classic Classic list List threaded Threaded
22 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

            Bug ID: 231110
           Summary: GTK print dialogs falsely believe lpr cannot accept
                    PDF
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email], [hidden email]

Created attachment 196805
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=196805&action=edit
Patch to tell GTK that lpr accepts PDF output

The LPR backend for GTK asserts that "lpr" cannot accept PDF files.  Granted,
you can't tell in general whether lpr in a given situation will be able to
print a PDF or not, but declaring that it can't is needlessly restrictive.  The
attached patch (works for both GTK2 and GTK3) adds the "accepts-pdf" property
to the lpr backend and fixes the problem.

This patch is suggested as an alternative to the patch from the freebsd-gecko
email thread "firefox-60.0_2,1 missing 'Print to LPR'", from May 13, 2018,
which circumvents the problem by generating PostScript output instead of PDF.
Fixing the problem in GTK means that other users of GTK won't have to create
parallel workarounds.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|GTK print dialogs falsely   |x11-toolkits/gtk20: GTK
                   |believe lpr cannot accept   |print dialogs falsely
                   |PDF                         |believe lpr cannot accept
                   |                            |PDF
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #1 from Jan Beich <[hidden email]> ---
Walter, firefox doesn't use gtk20 (except for Adobe Flash plugin) but the patch
applies against both gtk20 and gtk30.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #2 from [hidden email] ---
Is it legal to cite two port names in the title of the bug?  The problem (and
the patch) apply to both gtk2 and gtk3.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|x11-toolkits/gtk20: GTK     |x11-toolkits/gtk20,
                   |print dialogs falsely       |x11-toolkits/gtk30: GTK
                   |believe lpr cannot accept   |print dialogs falsely
                   |PDF                         |believe lpr cannot accept
                   |                            |PDF

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #3 from [hidden email] ---
No problem (was my error with the title).

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

Sean Farley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #4 from Sean Farley <[hidden email]> ---
I had written a patch, that I had forgotten, that looks similar to yours.  It
has a few differences.  I am not the best with GTK code, so I have no idea
which is correct between your patch or mine in relation to the backend and
is-virtual settings.  I also include accepts-ps in the function call as the lpr
filter I am using handles both.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

Sean Farley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196976|text/x-csrc                 |text/plain
          mime type|                            |

--- Comment #5 from Sean Farley <[hidden email]> ---
Created attachment 196976
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=196976&action=edit
Alternate patch to fix GTK

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #6 from [hidden email] ---
I know less about GTK probably than anyone else on the project, so someone else
should probably choose between these two patches.  But the other backends don't
specify "accepts-ps", so I assumed it was the default.  Also, I wrote
"GTK_PRINT_BACKEND (backend)" simply because that looked similar to what I saw
in the other backends.

But it does seem to me like a very good idea to incorporate one of these
patches.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #7 from Jan Beich <[hidden email]> ---
Have you tried to submit the patch/rationale upstream? gnome@ (downstream) is
understaffed and, probably, doesn't have enough expertise to review.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #8 from [hidden email] ---
Offhand, I wouldn't know how to do that ...

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #9 from Sean Farley <[hidden email]> ---
I created an account on Gnome's GitLab server and created an issue for this:
https://gitlab.gnome.org/GNOME/gtk/issues/1385

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #10 from Sean Farley <[hidden email]> ---
I created a pull request in the Gnome repo.  It was marked for GTK4.
https://gitlab.gnome.org/GNOME/gtk/merge_requests/418

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #11 from Victor Sudakov <[hidden email]> ---
Ping! There are more people who are missing the LPR printing capability in
Firefox!

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #12 from Victor Sudakov <[hidden email]> ---
GIMP from ports still can "Print to LPR", I double-checked 10 minutes ago.

And yes, ghostscript now accepts PDF input just find, so you can configure a
"ps" printer and print PDFs to it. This is what I've done.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #13 from Sean Farley <[hidden email]> ---
I must admit to having forgotten about this since I have been running happily
with the patch I submitted upstream in September 2018.

It should hopefully go into GTK4, but I have not followed what the status of
that is.  Also, we would have to wait until Firefox moves to GTK4.  I think it
should be added to ports as patch since it may be quite awhile before we see it
in the applications we use.  Unless, someone has push upstream to get it into
GTK3.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #14 from [hidden email] ---
Lacking any pull with the upstream project, I've been hoping one or the other
of these patches would be adopted by FreeBSD for the port since I submitted the
bug.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #15 from Victor Sudakov <[hidden email]> ---
(In reply to Sean Farley from comment #13)
> I have been running happily with the patch I submitted upstream in September 2018.

Does it still apply cleanly to current www/firefox ? Anyway, I'd hate to build
firefox locally, it's too resource- and time-consuming.

Could we ask the port maintainer to add this patch to the FreeBSD ports tree? I
see no harm in it.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #16 from [hidden email] ---
A commit references this bug:

Author: jbeich
Date: Mon May 11 13:11:53 UTC 2020
New revision: 534912
URL: https://svnweb.freebsd.org/changeset/ports/534912

Log:
  www/firefox: backport NSS 3.52 support after r533597

  PR:           231110
  Reported by:  Tomasz "CeDeROM" CEDRO, Roman

Changes:
  head/www/firefox/Makefile
  head/www/firefox/files/patch-bug1624128

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231110] x11-toolkits/gtk20, x11-toolkits/gtk30: GTK print dialogs falsely believe lpr cannot accept PDF

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231110

--- Comment #17 from Jan Beich <[hidden email]> ---
Sorry, I've copy-pasted the wrong bug number into PR field. comment 16 belongs
in bug 246363.

(In reply to Victor Sudakov from comment #15)
> Does it still apply cleanly to current www/firefox ?

There're no patches against www/firefox in this bug. Revert from
https://lists.freebsd.org/pipermail/freebsd-gecko/2018-May/008327.html doesn't
apply due to high code churn uptream.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
12