[Bug 231277] dns/ddclient: perl SHEBANG wrong

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

            Bug ID: 231277
           Summary: dns/ddclient: perl SHEBANG wrong
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email]
                CC: [hidden email]
             Flags: maintainer-feedback?([hidden email])

Running dns/ddclient on a 12-CURRENT router facility reveals some problems
lately and investigating /usr/local/sbin/ddclient (PERL 5 script) reveals, that
the SHEBANG header is comprised from:

#!/usr/local/bin/perl -w
#!/usr/local/local/bin/perl -w
######################################################################
#
# DDCLIENT - a Perl client for updating DynDNS information
#
# Author: Paul Burry ([hidden email])
[...]

The second line seems clearly wrong.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #1 from [hidden email] ---
Can you please address this with upstream.  ddclient works as it is, and you
haven't reported a bug that impacts anyone as best i can tell.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #2 from O. Hartmann <[hidden email]> ---
Why should I address something with upstream when it is clearly a fault of the
port maintenance?

The original perl main program's shebang is

#!/usr/bin/perl -w
#!/usr/local/bin/perl -w
######################################################################
[...]


and after application of the patch (tagged post-patch) it is

#!/usr/local/bin/perl -w
#!/usr/local/local/bin/perl -w
######################################################################
[...]

as reported. And now: who is to blame? Upstream?

The problem is identified rather quickly:

post-patch:
        @${GREP} -lR '/usr' ${WRKSRC} | ${XARGS} ${REINPLACE_CMD} -e \
                's|/usr|${PREFIX}|g'

It is surely more of a cosmetic question, but I'm not sure about nasty side
effects. It should be fixed - locally at FreeBSD's, not upstream.

But how do you think about the attached patch? Also cosmetic (I'd prefer
/usr/bin/env -S perl -w )?

Regards,

oh

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #3 from O. Hartmann <[hidden email]> ---
Created attachment 197003
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=197003&action=edit
Get rid of a wrong shebang statement in ddclient

Delete a wrong shebang statement in ddclient.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #4 from [hidden email] ---
My understanding is that it is not valid to have two shebang lines.

My interpretation of your response is that you agree that this is a cosmetic
change rather than a bug that impacts anyone.

These two factors are behind my request that this be dealt with upstream.

In terms of a patch, if one must be applied, it seems to me the optimum
approach is to remove the second shebang from the source code, and use

https://www.freebsd.org/doc/en/books/porters-handbook/uses-shebangfix.html

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

Nathan <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Nathan <[hidden email]> ---
I agree, there should not be two #! lines, upstream needs to get rid of one and
then we can let shebangfix do the rest

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #6 from Nathan <[hidden email]> ---
(In reply to Nathan from comment #5)
To add on, I think i know why the 2nd line of #! in regards to Comment#0 is
because of REINPLACE_CMD. I've seen sed do something similar when I was using
sed to replace some text, and it made a bit redundant replacements

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #7 from Nathan <[hidden email]> ---
Actually looking at it, wouldn't need shebang fix.
Get rid of:
  @${GREP} -lR '/usr' ${WRKSRC} | ${XARGS} ${REINPLACE_CMD} -e \
                        's|/usr|${PREFIX}|g'

do
${REINPLACE_CMD} -e '1d ; s,/usr/bin,${PREFIX}/bin,g' ${WRKSRC}/ddclient

This will delete first #! leaving the correct path we need in FreeBSD, 2nd part
fixes rest of /usr/bin in file

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #8 from [hidden email] ---
When I looked at ddclient after make patch, I didn't see any other use of /usr
that we wanted changed to ${PREFIX} that wasn't handled in patch-ddclient
already.  This is all about a shebang.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #9 from Nathan <[hidden email]> ---
Yup. then 2nd part of my REINPLACE_CMD wouldn't be needed if patch took care of
rest

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

Walter Schwarzenfeld <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Walter Schwarzenfeld <[hidden email]> ---
ping!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |merge-quarterly?
           Severity|Affects Many People         |Affects Some People
           Keywords|                            |needs-patch
             Status|New                         |Open

--- Comment #11 from Kubilay Kocak <[hidden email]> ---
@Maintainer, Can you please produce a patch against the port if there is a
change to be made or bug to be fixed

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-qa

--- Comment #12 from Kubilay Kocak <[hidden email]> ---
Alternatively, review and accept/not-accept attachment 197003 with rationale in
the latter case.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197003|                            |maintainer-approval?(mjl@lu
              Flags|                            |ckie.org.nz)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197003|maintainer-approval?(mjl@lu |maintainer-approval+
              Flags|ckie.org.nz)                |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

--- Comment #13 from [hidden email] ---
(In reply to Kubilay Kocak from comment #12)
the patch is maintainer approved

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231277] dns/ddclient: perl SHEBANG wrong

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231277

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(mjl@lu |maintainer-feedback+
                   |ckie.org.nz)                |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"