[Bug 231332] [patch] qa.sh: fix flavor detection for LIB_DEPENDS

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 231332] [patch] qa.sh: fix flavor detection for LIB_DEPENDS

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231332

            Bug ID: 231332
           Summary: [patch] qa.sh: fix flavor detection for LIB_DEPENDS
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email]

Created attachment 197060
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=197060&action=edit
qa.sh: use package name instead of port origin

qa.sh uses `pkg annotate -q -S $origin flavor` to get the flavor of file's
package.  However, if there are multiple flavors of a port origin installed
then things brake:

# pkg info -E multimedia/phonon
phonon-qt4-4.10.1
phonon-qt5-4.10.1
# pkg annotate -q -S multimedia/phonon flavor
qt4
qt5

The attached patch ensures ensures the full package name is used, instead of
the origin.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231332] [patch] qa.sh: fix flavor detection for LIB_DEPENDS

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231332

--- Comment #1 from Mathieu Arnold <[hidden email]> ---
Could you provide a port that is broken, to test this?

Or a port that can be broken to test it?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231332] [patch] qa.sh: fix flavor detection for LIB_DEPENDS

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231332

--- Comment #2 from David Naylor <[hidden email]> ---
If you have both versions of phonon installed then audio/soundkonverter will
fail stage-qa.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231332] [patch] qa.sh: fix flavor detection for LIB_DEPENDS

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231332

--- Comment #3 from David Naylor <[hidden email]> ---
Any objections against committing this patch?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231332] Mk/Scripts/qa.sh: Fix flavor detection for LIB_DEPENDS

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231332

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
            Summary|[patch] qa.sh: fix flavor   |Mk/Scripts/qa.sh: Fix
                   |detection for LIB_DEPENDS   |flavor detection for
                   |                            |LIB_DEPENDS
              Flags|                            |merge-quarterly?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231332] Mk/Scripts/qa.sh: Fix flavor detection for LIB_DEPENDS

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231332

Mathieu Arnold <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |Closed
         Resolution|---                         |FIXED

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 231332] Mk/Scripts/qa.sh: Fix flavor detection for LIB_DEPENDS

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231332

--- Comment #4 from [hidden email] ---
A commit references this bug:

Author: mat
Date: Fri Jan 11 12:50:52 UTC 2019
New revision: 489958
URL: https://svnweb.freebsd.org/changeset/ports/489958

Log:
  Fix proxydeps QA check when multiple flavor of a package are installed.

  Previously it would do this:

  $ pkg which -q -o /usr/local/lib/libphonon4qt5.so
  multimedia/phonon
  $ pkg pkg annotate -q -S multimedia/phonon flavor
  qt4
  qt5

  And that would break things in an interesting way.

  This changes makes it use the package name of the required file, which
  is unique.

  Note that this problem would probably only ever happen on a live system.
  I was not able to find a single port that would trigger this it in a
  clean environment (poudriere testport).

  PR:           231332
  Submitted by: dbn

Changes:
  head/Mk/Scripts/qa.sh

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"