[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

            Bug ID: 235240
           Summary: devel/libinotify: move sys/inotify.h into a
                    subdirectory
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email], [hidden email],
                    [hidden email]
          Assignee: [hidden email]
             Flags: maintainer-feedback?([hidden email])
             Flags: maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email]),
                    maintainer-feedback?([hidden email])
                CC: [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email],
                    [hidden email], [hidden email], [hidden email],
                    [hidden email]

libinotify installs sys/inotify.h in a common location where regular libraries
are. Consumers may opportunistically pick it up over kqueue backend or if not
required. Let's limit poisoning like OpenBSD port did.

See review D18990 for the patch and check your port didn't regress.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
Jan Beich <[hidden email]> has asked freebsd-java mailing list
<[hidden email]> for maintainer-feedback:
Bug 235240: devel/libinotify: move sys/inotify.h into a subdirectory
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240



--- Description ---
libinotify installs sys/inotify.h in a common location where regular libraries
are. Consumers may opportunistically pick it up over kqueue backend or if not
required. Let's limit poisoning like OpenBSD port did.

See review D18990 for the patch and check your port didn't regress.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Jan Beich <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]         |[hidden email]
              Flags|                            |exp-run?

--- Comment #1 from Jan Beich <[hidden email]> ---
Can you check all ports for hidden consumers?

OPTIONS_SET += LIBINOTIFY INOTIFY FSMONITOR

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(madpil |maintainer-feedback+
                   |[hidden email])             |

--- Comment #2 from Guido Falsi <[hidden email]> ---
I filed some feedback in the code review.

Short version is, I think this could be better addressed creating an inotify
USES.

I'm restraining my approval until such concern is addressed.

Posting here to avoid timing out.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Alexandre C. Guimarães <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(rigole |maintainer-feedback+
                   |[hidden email])            |

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Tobias C. Berner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(kde@Fr |maintainer-feedback+
                   |eeBSD.org)                  |
                 CC|                            |[hidden email]

--- Comment #3 from Tobias C. Berner <[hidden email]> ---
Looks good for kde@, as long as it is exp-ran.

mfg Tobias

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Yuri Victorovich <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(yuri@f |maintainer-feedback+
                   |reebsd.org)                 |

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Bernhard Froehlich <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(decke@ |maintainer-feedback+
                   |FreeBSD.org)                |

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

--- Comment #4 from Josh Paetzel <[hidden email]> ---
I patched devel/libinotify, then installed devel/py-pyinotify and confirmed it
works properly.  All clear from me.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Gleb Popov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(haskel |maintainer-feedback+
                   |[hidden email])              |
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

--- Comment #5 from Sunpoet Po-Chuan Hsieh <[hidden email]> ---
(In reply to Jan Beich from comment #0)

I'm OK to change where inotify.h installs. But I do not understand why we have
to move it. Could you please give a case that "consumers may opportunistically
pick it up over kqueue backend or if not required"? After this change, do we
have to teach every new ports how to find the new home of inotify.h?

Thanks.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

--- Comment #6 from Jan Beich <[hidden email]> ---
(In reply to Sunpoet Po-Chuan Hsieh from comment #5)
> Could you please give a case that "consumers may opportunistically
> pick it up over kqueue backend or if not required"?

Look for ports with CONFIGURE_ENV=ac_cv_header_sys_inotify_h=no.

> After this change, do we have to teach every new ports how to find the new home of inotify.h?

No. Only those not using pkg-config. -linotify doesn't exist on Linux, so it
always comes with a .pc file (unless older than 20170711). autotools and meson
support pkg-config just fine, cmake uses modules to reinvent pkg-config but the
support is good if required module exists, gmake and bmake[1] can cache
pkg-config output via $(shell ...) and ${SH:!...!}.

[1] bmake caching have to be in submake *after* pkg-config is installed as
${SH:!...!} is evaluated at parsing time. gmake isn't affected because it's
only used to parse vendor's Makefile while port's Makefile is parsed by bmake.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Koop Mast <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(kwm@Fr |maintainer-feedback+
                   |eeBSD.org)                  |

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

Dominik Lisiak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(domini |maintainer-feedback+
                   |[hidden email])        |

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 235240] devel/libinotify: move sys/inotify.h into a subdirectory

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235240

--- Comment #7 from Dominik Lisiak <[hidden email]> ---
I didn't apply the patch, but made a compatible fix in bug #236919 for
security/ossec-hids-local.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-java
To unsubscribe, send any mail to "[hidden email]"