[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

            Bug ID: 236166
           Summary: misc/xfce4-weather-plugin: Fix sunrise API
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch-ready
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
             Flags: maintainer-feedback?([hidden email])
          Assignee: [hidden email]
             Flags: merge-quarterly?

Created attachment 202510
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202510&action=edit
Fix sunrise API

Currently, misc/xfce4-weather-plugin still uses the 1.1 sunrise API, but it has
expired [1]. This patch updates to the latest API (2.0, see my comment on
Xfce's Bugzilla [2] for details).

Manual intervention is required (through UPDATING or pkg-message). Users need
to remove ~/.cache/xfce4/weather/ directory.

A commit in quarterly branch is needed too.

[1] https://api.met.no/weatherapi/sunrise/2.0/documentation
[2] https://bugzilla.xfce.org/show_bug.cgi?id=14972#c9

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
Bugzilla Automation <[hidden email]> has asked freebsd-xfce mailing list
<[hidden email]> for maintainer-feedback:
Bug 236166: misc/xfce4-weather-plugin: Fix sunrise API
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166



--- Description ---
Currently, misc/xfce4-weather-plugin still uses the 1.1 sunrise API, but it has
expired [1]. This patch updates to the latest API (2.0, see my comment on
Xfce's Bugzilla [2] for details).

Manual intervention is required (through UPDATING or pkg-message). Users need
to remove ~/.cache/xfce4/weather/ directory.

A commit in quarterly branch is needed too.

[1] https://api.met.no/weatherapi/sunrise/2.0/documentation
[2] https://bugzilla.xfce.org/show_bug.cgi?id=14972#c9
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress
              Flags|maintainer-feedback?(xfce@F |maintainer-feedback+
                   |reeBSD.org)                 |
                 CC|                            |[hidden email]

--- Comment #1 from Guido Falsi <[hidden email]> ---
I'm testing the patch.

Reading the comments on the XFCE bug, it looks like the manual intervention is
not actually needed, am I correct?


Also, is this a security related issue? if not I don't think it is eligible for
merging to quarterly. Anyway a new quarterly will be branched in a month at
most.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

--- Comment #2 from Olivier Duchateau <[hidden email]> ---
(In reply to Guido Falsi from comment #1)

Yes, you are right, no manual intervention is required.

Merge into quarterly, is for deprecated 1.1 API. It is not security issue
(avoid no response from met.no service).

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://bugzilla.xfce.org/s
                   |                            |how_bug.cgi?id=14972

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

--- Comment #3 from [hidden email] ---
A commit references this bug:

Author: madpilot
Date: Wed Mar  6 10:52:15 UTC 2019
New revision: 494787
URL: https://svnweb.freebsd.org/changeset/ports/494787

Log:
  Import patch from upstream bug report for xfce4-weather-plugin to
  adapt to new upstream weather service API interface.

  Previous API version is deprecated and expired by upstream.

  While here, remove unneeded USES=intlhack.

  PR:           236166
  Submitted by: Olivier Duchateau <[hidden email]>
  Obtained from:        https://bugzilla.xfce.org/show_bug.cgi?id=14972
  MFH:          2019Q1

Changes:
  head/misc/xfce4-weather-plugin/Makefile
  head/misc/xfce4-weather-plugin/files/
  head/misc/xfce4-weather-plugin/files/patch-new_sunrise_API

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

--- Comment #4 from Guido Falsi <[hidden email]> ---
Committed. I unified the various patch file sin one patch, which seems more
logical to me, since they're just one change actually.

Keeping bug open till I get a reply to MFH request.


Thanks for the patch!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

--- Comment #5 from [hidden email] ---
A commit references this bug:

Author: madpilot
Date: Wed Mar  6 11:45:30 UTC 2019
New revision: 494791
URL: https://svnweb.freebsd.org/changeset/ports/494791

Log:
  MFH: r494787

  Import patch from upstream bug report for xfce4-weather-plugin to
  adapt to new upstream weather service API interface.

  Previous API version is deprecated and expired by upstream.

  While here, remove unneeded USES=intlhack.

  PR:           236166
  Submitted by: Olivier Duchateau <[hidden email]>
  Obtained from:        https://bugzilla.xfce.org/show_bug.cgi?id=14972

  Approved by:  ports-secteam (joneum)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/misc/xfce4-weather-plugin/Makefile
  branches/2019Q1/misc/xfce4-weather-plugin/files/

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Progress                 |Closed
         Resolution|---                         |FIXED

--- Comment #6 from Guido Falsi <[hidden email]> ---
Merged too.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236166] misc/xfce4-weather-plugin: Fix sunrise API

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236166

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|merge-quarterly?            |merge-quarterly+

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"