[Bug 236216] devel/valgrind: clang 8 crashes during build

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Bug 236216] devel/valgrind: clang 8 crashes during build

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236216

--- Comment #4 from Dimitry Andric <[hidden email]> ---
Created attachment 202554
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202554&action=edit
Reuse existing offsetof macro for clang 8's sake

This is regressed by upstream https://reviews.llvm.org/rL349561 ("Emit ASM
input in a constant context"), and I already filed an upstream bug here:

https://bugs.llvm.org/show_bug.cgi?id=40890

The cause is the custom my_offsetof() macro in genoffsets, which returns a
pointer, not an offset.  The attached patch makes it reuse the already existing
offsetof() macro from VEX/pub/libvex_basictypes.h, which does the right thing.

I think this is an acceptable workaround until upstream fixes the issue with
<https://reviews.llvm.org/rL349561>, or even as a permanent cleanup.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "[hidden email]"