[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

            Bug ID: 236417
           Summary: x11/xfce4-screenshooter-plugin: Update to 1.9.4
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch-ready
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
             Flags: maintainer-feedback?([hidden email])
          Assignee: [hidden email]

Created attachment 202736
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202736&action=edit
Patch to update x11/xfce4-screenshooter-plugin

Update to 1.9.4

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
Bugzilla Automation <[hidden email]> has asked freebsd-xfce mailing list
<[hidden email]> for maintainer-feedback:
Bug 236417: x11/xfce4-screenshooter-plugin: Update to 1.9.4
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417



--- Description ---
Update to 1.9.4
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Status|New                         |In Progress
              Flags|maintainer-feedback?(xfce@F |maintainer-feedback+
                   |reeBSD.org)                 |

--- Comment #1 from Guido Falsi <[hidden email]> ---
Thanks I'm also testing a similar patch.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Progress                 |Open

--- Comment #2 from Guido Falsi <[hidden email]> ---
Port update itself works fine, but when trying to use it it's failing to save
screenshots to disk.

Using the "save" option causes an error message:

Failed to open "<home dir>" for writing: Is a directory


Looking at git history the file saving code was heavily refactored and updated.
Something must have been broken on the way.

Looks like the code fails to append a filename when actually saving the
screenshot to disk.

I'm trying to investigate this and maybe I'll file a bug report upstream.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://bugzilla.xfce.org/s
                   |                            |how_bug.cgi?id=15187

--- Comment #3 from Guido Falsi <[hidden email]> ---
Filed a bug report upstream.

The problem happens only when using the panel plugin.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

--- Comment #4 from Olivier Duchateau <[hidden email]> ---
(In reply to Guido Falsi from comment #2)

I encountered this bug, since several previous releases (only on FreeBSD, not
under Linux) when I save picture, with default filename. I don't know it's same
behaviour.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

--- Comment #5 from Guido Falsi <[hidden email]> ---
(In reply to Olivier Duchateau from comment #4)
> (In reply to Guido Falsi from comment #2)
>
> I encountered this bug, since several previous releases (only on FreeBSD,
> not under Linux) when I save picture, with default filename. I don't know
> it's same behaviour.

I have just tested in VMs.

Previous (1.9.3) version in FreeBSD does not show the broken behaviour. It did
show the file requester when sending a screenshot to a file via the panel
plugin.


I also tested in a Linux Manjaro VM I have, they just updated heir packages to
include version 1.9.4 and I can see the same broken behaviour there, so it IS
present in linux too.

Can be easily reproduced by adding the screenshoot plugin to the panel, left
clicking on it and accepting the default (saving to file).


It definitely looks like a regression.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

--- Comment #6 from Olivier Duchateau <[hidden email]> ---
(In reply to Guido Falsi from comment #5)

I think I find the problem (not yet tested, it will wait tomorrow). In
action_idle function (lib/screenshooter-actions.c):

>      if (!sd->path_is_dir)
>        screenshooter_save_screenshot_to (sd->screenshot, sd->screenshot_dir);
>      else

2nd member of 'screenshooter_save_screenshot_to' must be a filename (see
lib/screenshooter-dialogs.c) and not a directory.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

--- Comment #7 from Olivier Duchateau <[hidden email]> ---
(In reply to Olivier Duchateau from comment #6)

In config file (~/.config/xfce4/xfce4-screenshooter) value of screenshot_dir is
path to folder.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Open                        |In Progress

--- Comment #8 from Guido Falsi <[hidden email]> ---
Version 1.9.5 with a fix for the issue I reported is out.

I'm going to commit an update to this version shortly.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

--- Comment #9 from [hidden email] ---
A commit references this bug:

Author: madpilot
Date: Sun Mar 31 18:47:23 UTC 2019
New revision: 497439
URL: https://svnweb.freebsd.org/changeset/ports/497439

Log:
  Update xfce4-screenshooter-plugin to 1.9.5

  PR:           236417
  Submitted by: Olivier Duchateau <[hidden email]>

Changes:
  head/x11/xfce4-screenshooter-plugin/Makefile
  head/x11/xfce4-screenshooter-plugin/distinfo

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236417] x11/xfce4-screenshooter-plugin: Update to 1.9.4

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236417

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|In Progress                 |Closed

--- Comment #10 from Guido Falsi <[hidden email]> ---
Update committed. Thanks!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"