[Bug 236438] [PATCH] x11-fm/thunar: add debug option

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

            Bug ID: 236438
           Summary: [PATCH] x11-fm/thunar: add debug option
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
          Assignee: [hidden email]
             Flags: maintainer-feedback?([hidden email])

Created attachment 202764
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202764&action=edit
add options

Add DEBUG option

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
Bugzilla Automation <[hidden email]> has asked freebsd-xfce mailing list
<[hidden email]> for maintainer-feedback:
Bug 236438: [PATCH] x11-fm/thunar: add debug option
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438



--- Description ---
Add DEBUG option
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |easy

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202764|0                           |1
        is obsolete|                            |

--- Comment #1 from [hidden email] ---
Created attachment 202941
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202941&action=edit
install-strip only if no debug

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202941|                            |maintainer-approval?
              Flags|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |[hidden email]

--- Comment #2 from Guido Falsi <[hidden email]> ---
Hi,

Thanks for the patch, I had a look. While I do agree with adding DEBUG support,
I think it should be done the "proper" way.

In the ports tree there is support for the "WITH_DEBUG" flag, which
automatically disables optimizations, adds the -g flag and disables stripping
of binaries(or at least tries to).

If a port needs further flags they should be linked to this flag.

I have also discovered that DEBUG options are not a good idea [1]

So I'd rework this patch to not add a DEBUG option to the port but use the
WITH_DEBUG (which is also triggere by WITH_DEBUG_PORTS) flag to check if extrra
options should be enabled.

I'd try to avoid a DEBUG option. Adding WITH_DEBUG_PORTS to make.conf is quite
easy.


[1] https://reviews.freebsd.org/D15773

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

--- Comment #3 from [hidden email] ---
(In reply to Guido Falsi from comment #2)

Adding WITH_DEBUG_PORTS has less usability, IMHO, but ok.
Review has no progress for a long time. :(
Same changes can be done for devel/glib20.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236438] [PATCH] x11-fm/thunar: add debug option

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438

--- Comment #4 from Guido Falsi <[hidden email]> ---
(In reply to rozhuk.im from comment #3)
> (In reply to Guido Falsi from comment #2)
>
> Adding WITH_DEBUG_PORTS has less usability, IMHO, but ok.

Depends. If you want a bunch of ports with debugging symbols it's easier to use
that than set DEBUG option in them.

Anyway, even if providing an options we need to hook with WITH_DEBUG framework.

> Review has no progress for a long time. :(

The review I referenced is abandoned, since I got negative feedback and was
convinced by the arguments there.

> Same changes can be done for devel/glib20.

Yes...well...I've been debugging both thunar and glib20 using "WITH_DEBUG" as
is and did get useful backtraces...


Anyway, will you be providing a revised patch? Otherwise I can cook it up, but
not right away.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"