[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

            Bug ID: 236625
           Summary: [PATCH] x11/xfce4-taskmanager: icons not shown, wrong
                    wnck lib
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
          Assignee: [hidden email]
             Flags: maintainer-feedback?([hidden email])

Created attachment 202969
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202969&action=edit
patch

After switch to gtk3 icons not shown, because wnck3 should be used with gtk3,
but used wnck.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
Bugzilla Automation <[hidden email]> has asked freebsd-xfce mailing list
<[hidden email]> for maintainer-feedback:
Bug 236625: [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625



--- Description ---
After switch to gtk3 icons not shown, because wnck3 should be used with gtk3,
but used wnck.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |easy
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202969|                            |maintainer-approval?
              Flags|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress
                 CC|                            |[hidden email]

--- Comment #1 from Guido Falsi <[hidden email]> ---
Thanks for reporting. I'll commit after some testing.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

--- Comment #2 from Guido Falsi <[hidden email]> ---
BTW, this got past me in testing because I rarely use this application, so the
absence of the icons did not strike my eye as something strange. I simply did
not expect icons to be there!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

--- Comment #3 from [hidden email] ---
I use it every day many times.
Icons lost after migration to gtk3, it was dissapointing to me and I was
thinking that it is gtk3 issue.

Tonight I build taskmanager in CodeLite to debug and fix icon missing and it
does not start until I change wnck-1.0 to wnck-3.0, after start I see icons :)
Now I am looking for how to save setting in quit via tray menu.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #202969|maintainer-approval?        |maintainer-approval+
              Flags|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

--- Comment #4 from Guido Falsi <[hidden email]> ---
I understand your disappointment.

I wanted to explain why I did not notice this regression in testing before the
update.

I'm committing shortly.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(xfce@F |maintainer-feedback+
                   |reeBSD.org)                 |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

--- Comment #5 from [hidden email] ---
A commit references this bug:

Author: madpilot
Date: Tue Mar 19 14:38:13 UTC 2019
New revision: 496260
URL: https://svnweb.freebsd.org/changeset/ports/496260

Log:
  Fix regression after migration to GTK3, icons not showing.

  PR:           236625
  Submitted by: [hidden email]

Changes:
  head/x11/xfce4-taskmanager/Makefile

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

Guido Falsi <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|In Progress                 |Closed

--- Comment #6 from Guido Falsi <[hidden email]> ---
Fix committed.

Thanks!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

--- Comment #7 from [hidden email] ---
A bit strange to not disable wnck, but IMHO configure script handle this.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

Olivier Duchateau <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Olivier Duchateau <[hidden email]> ---
libwnck3 was enabled when I submitted my patch bug #200311, but not when it was
committed.
So it is not regression! libwnck3 is targeted for Gtk3.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 236625] [PATCH] x11/xfce4-taskmanager: icons not shown, wrong wnck lib

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236625

--- Comment #9 from Guido Falsi <[hidden email]> ---
I did not mean to make any fuss about this.

Maybe my choice of words was a poor one.

By regression I meant to the regression I caused in the ports with my commit.
I, due to a mistake, did not include that part of you patch, and while testing
I did not notice the absence of the icons, due to the fact that I rarely use
this tool, so I did not notice their absence,m not being used to the appearance
of this software.

I did not intend to mean anything more than this, and did not want to put blame
on anyone else.

I made a (small luckily) mistake and am sorry for that.

Thanks to rozhuk for reporting it and helping me fix it.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "[hidden email]"