[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

            Bug ID: 238988
           Summary: [exp-run] convert bsd.xorg.mk to USES=xorg and
                    USES=xorg-cat
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email]

Converting bsd.xorg.mk, USE_XORG and XORG_CAT to USES=xorg and USES=xorg-cat.
This needs an exp-run.  Patch can be found in the following review:
https://reviews.freebsd.org/D20724

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

Niclas Zeising <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |exp-run?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

--- Comment #1 from Niclas Zeising <[hidden email]> ---
What is the status of this?  It's been almost 2 weeks and I haven't heard
anything?

Looking at the phabricator review, everything has been taken care of, and tijl
has accepted the solution to the issues I had with libtool and autoreconf, as
can be seen here: https://reviews.freebsd.org/D20724#451574 .

The only thing is tcberner@ asked about the variable names, and the backwards
compat code to allow USE_XORG= without USES=xorg, but those should not stop the
exp run.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

Niclas Zeising <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |216591


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216591
[Bug 216591] Mk/bsd.xorg.mk: support :build
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

--- Comment #2 from Niclas Zeising <[hidden email]> ---
Patch has been updated in phabricator.  I believe it's ready for an exp-run.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

Antoine Brodin <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|exp-run?                    |exp-run+

--- Comment #3 from Antoine Brodin <[hidden email]> ---
Exp-run looks fine

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

--- Comment #4 from [hidden email] ---
A commit references this bug:

Author: zeising
Date: Mon Aug 26 09:45:18 UTC 2019
New revision: 509895
URL: https://svnweb.freebsd.org/changeset/ports/509895

Log:
  Change bsd.xorg.mk to USES=xorg and USES=xorg-cat

  Change the handling of xorg dependencies to use the USES framework instead
  of bsd.xorg.mk.  bsd.xorg.mk is split into two parts:
  * USES=xorg for ports depending on xorg ports with USE_XORG
  * USES=xorg-cat for xorg ports with XORG_CAT

  USES=xorg is fairly straight forward.  The components needed are specified
  with USE_XORG, and USES=xorg is needed to pull in this part of the
  framework.

  USES=xorg-cat requires that the category, previously specified with
  XORG_CAT, now be passed as an argument to xorg-cat, like this
  USES=xorg-cat:category.  Not specifying a category is an error.
  Further, it is also possible to specify which build system to use.  The
  default if nothing is specified is autoconf, but meson will also be
supported.
  This is added with a second argument: USES=xorg-cat:category[,buildsystem].

  Detailed changelog:
  * Add support in Uses/xorg-cat.mk to specify build system.  Previously, only
    autoconf was supported for xorg ports, but with this change, it's possible
    to use meson instead.  Autoconf is still the defaultx, if nothing else is
    specified.  The meson support is still disabled, and requires more testing.
  * Add support in Uses/xorg-cat.mk to pull sources from freedesktop.org
    gitlab.
    When specifying USE_GITLAB in a port using xorg-cat, then various GL_*
    variables will be set up automatically, as well as needed changes to the
    build.
  * Switch x11-drivers/xf86-video-intel to use the USE_GITLAB framework.
  * While touching xf86-video-intel, switch to USES=xorg xorg-cat:driver, and
    pet portlint.
  * Add compat shims and warnings to bsd.port.mk, which will handle the old
    style ports Makefiles.
  * Change Uses/gl.mk and Uses/motif.mk to use this new framework.
  * Change Uses/autoreconf.mk to check and add dependencies later.  This is
    needed because xorg-cat uses autoreconf, and without this fix
    dependencies were not added properly.
  * Be stricter about checking for arguments in USE_XORG, previously, :build
    and :run were accepted, but not supported.  Only the default or :both
    supported.
  * Change multimedia/gstreamer1-vaapi to handle the stricter argument
    checking in USE_XORG, and add USES=xorg
  * change x11/xscope to get distinfo from xorg-cat, instead of rolling it's
    own, and add USES=xorg-cat

  PR:           238988 (exp-run)
  Reviewed by:  antoine, tcberner, tijl, mat, tobik
  Approved by:  portmgr (antoine)
  Obtained from:        FreeBSD Graphics Team development repo
               
https://github.com/FreeBSDDesktop/freebsd-ports/tree/feature/usesxorg
  Sponsored by: B3 Init (zeising)
  Differential Revision:        https://reviews.freebsd.org/D20724

Changes:
  head/Mk/Uses/autoreconf.mk
  head/Mk/Uses/gl.mk
  head/Mk/Uses/motif.mk
  head/Mk/Uses/xorg-cat.mk
  head/Mk/Uses/xorg.mk
  head/Mk/bsd.port.mk
  head/Mk/bsd.xorg.mk
  head/multimedia/gstreamer1-vaapi/Makefile
  head/x11/xscope/Makefile
  head/x11-drivers/xf86-video-intel/Makefile
  head/x11-drivers/xf86-video-intel/distinfo

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

Niclas Zeising <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]         |[hidden email]

--- Comment #5 from Niclas Zeising <[hidden email]> ---
Changes have been committed.  Thanks for the help with the exp run!

I'll keep this PR open for a little while, in case there's fallout.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

Dmitri Goutnik <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #6 from Dmitri Goutnik <[hidden email]> ---
USES=gl now seems to produce warnings that "Using USE_XORG alone is deprecated,
please use USES=xorg" from bsd.port.mk:1923 even when port's Makefile doesn't
define USE_XORG (example port: devel/liteide)

Does USES=gl now imply that xorg is also required in USES?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

--- Comment #7 from Niclas Zeising <[hidden email]> ---
(In reply to Dmitri Goutnik from comment #6)

Hi!
That is not normal.  USES=gl pulls in xorg components in certain cases, but
it's handled by the framework.  I have to look into this spurious warning.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

Tobias Kortkamp <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
 Attachment #207543|                            |maintainer-approval?(x11@Fr
              Flags|                            |eeBSD.org)

--- Comment #8 from Tobias Kortkamp <[hidden email]> ---
Created attachment 207543
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207543&action=edit
gl.mk.diff

(In reply to Niclas Zeising from comment #7)
> Hi!
> That is not normal.  USES=gl pulls in xorg components in certain cases, but it's handled by the framework.  I have to look into this spurious warning.

Did you find a way to avoid it?  It is very annoying.  Bogus QA
warnings are not good and waste time.

I do not see how the warning could be avoided without creating new
false warnings elsewhere or doing some really complicated things.
IMHO we should keep this simple and move the USE_XORG=xorgproto
stuff out of gl.mk.  See the attached patch.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 238988] [exp-run] convert bsd.xorg.mk to USES=xorg and USES=xorg-cat

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238988

--- Comment #9 from Niclas Zeising <[hidden email]> ---
(In reply to Tobias Kortkamp from comment #8)

Hi!
The issue, if I've figured out things correctly, is the compat stuff in
bsd.port.mk around line 1935.  This is done to support things that define
USE_XORG after bsd.port.pre.mk is included.

I see a couple of options, either perhaps fix the ports that define USE_XORG
after bsd.port.pre.mk (that doesn't already have USES=xorg).  This is probably
the most correct option, since then this warning can be removed.

The other option is to check if USES=gl or USES=xorg-cat and then not print the
warning.

The third option might be to have Uses/gl.mk and Uses/xorg-cat.mk add
dependencies to something like _USE_XORG and then in Uses/xorg.mk pick those up
as well.

I'm not sure which of these solutions is best.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"