[Bug 239741] factor out hardcoding of "clangXYZ" in graphics/openshadinglanguage

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 239741] factor out hardcoding of "clangXYZ" in graphics/openshadinglanguage

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239741

            Bug ID: 239741
           Summary: factor out hardcoding of "clangXYZ" in
                    graphics/openshadinglanguage
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email]
             Flags: maintainer-feedback?([hidden email])
                CC: [hidden email]

Created attachment 206393
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206393&action=edit
patch to graphics/openshadinglanguage/Makefile

There are a number of places in the ports tree where the string "clang<version"
is called out.  When doing the work to identify stale versions of clang
tree-wide, these instances cause extra work.

Refactor this usage into LLVM_VER.

Note: this refactoring causes portlint to complain but IMHO this complication
is worth tolerating to help ease maintainability.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239741] factor out hardcoding of "clangXYZ" in graphics/openshadinglanguage

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239741

Mark Linimon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |239736


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239736
[Bug 239736] factor out hardcoding of "clangXYZ" in ports tree
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239741] factor out hardcoding of "clangXYZ" in graphics/openshadinglanguage

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239741

--- Comment #1 from Shane <[hidden email]> ---
doesn't accept me adding maintainer approval.

This change has been merged into pending update in bug #239588

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239741] factor out hardcoding of "clangXYZ" in graphics/openshadinglanguage

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239741

Mark Linimon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Closed
         Resolution|---                         |DUPLICATE
           Assignee|[hidden email]      |[hidden email]
              Flags|maintainer-feedback?(FreeBS |maintainer-feedback+
                   |[hidden email])            |

--- Comment #2 from Mark Linimon <[hidden email]> ---
Change now included in 239588 .

*** This bug has been marked as a duplicate of bug 239588 ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"