[Bug 239892] [PATCH] www/tomcat9: Support Java 9+

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] [PATCH] www/tomcat9: Support Java 9+

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

            Bug ID: 239892
           Summary: [PATCH] www/tomcat9: Support Java 9+
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
                CC: [hidden email]
                CC: [hidden email]
             Flags: maintainer-feedback?([hidden email])

Created attachment 206601
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206601&action=edit
rc script patch

The rc script for tomcat9 starts Java with the option:

-Djava.endorsed.dirs='${_tomcat_catalina_home}/endorsed'

On Java 9 and above, this will cause the JVM (and hence Tomcat) to not be able
to start.  See, e.g.,

https://docs.oracle.com/javase/10/migrate/

(Particularly "Removed Endorsed Standards Override Mechanism")

The attached patch detects the Java version and only passes this option to Java
if the version is less than 9.  A similar patch should likely also be applied
to other Tomcat versions (e.g. tomcat85)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] [PATCH] www/tomcat9: Support Java 9+

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

--- Comment #1 from VVD <[hidden email]> ---
(In reply to Greg Lewis from comment #0)
Did you forget pkg-plist diff or why did you add this line in Makefile:
"JAVA_VERSION=${JAVA_PORT_VERSION}"?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |feature, needs-qa
             Status|New                         |Open
            Summary|[PATCH] www/tomcat9:        |www/tomcat9: Support Java
                   |Support Java 9+             |9+

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

--- Comment #2 from Greg Lewis <[hidden email]> ---
That was to substitute for %%JAVA_VERSION%% in the change to the rc script.

It's not strictly necessary though.  I could instead default the version to
empty if it doesn't get determined and remove that change from the Makefile if
you'd prefer.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

--- Comment #3 from VVD <[hidden email]> ---
(In reply to Greg Lewis from comment #2)
There are no %%JAVA_VERSION%% in files/tomcat9.in…

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

--- Comment #4 from VVD <[hidden email]> ---
(In reply to VVD from comment #3)
Oh! Found it…

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

--- Comment #5 from VVD <[hidden email]> ---
(In reply to VVD from comment #4)
Java version must be runtime detected, but not build time.
Can you fix this in patch?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

VVD <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206651|                            |maintainer-approval+
              Flags|                            |

--- Comment #6 from VVD <[hidden email]> ---
Created attachment 206651
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206651&action=edit
Java 9+ support in tomcat9

Plz, test this patch.
It work for me on 12.0 amd64 with openjdk8 and openjdk11.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

VVD <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206652|                            |maintainer-approval+
              Flags|                            |

--- Comment #7 from VVD <[hidden email]> ---
Created attachment 206652
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206652&action=edit
Java 9+ support in tomcat85

Same for tomcat85.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

--- Comment #8 from VVD <[hidden email]> ---
I found other way to check java version:
> java -version 2>&1 | awk -F '"' '/version/ {print $2}'
What is more correct way?

> java -version 2>&1 | head -1 | sed -e 's/[^"][^"]*\"\([^\"]*\)\".*/\1/'

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

--- Comment #9 from Greg Lewis <[hidden email]> ---
I don't think one way is more correct than the other, they're just a different
way of essentially doing the same thing.  I'm ok with either.  If you prefer
the awk version then I have no problems with that.  It is certainly shorter.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

VVD <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206652|0                           |1
        is obsolete|                            |
 Attachment #206767|                            |maintainer-approval+
              Flags|                            |

--- Comment #10 from VVD <[hidden email]> ---
Created attachment 206767
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206767&action=edit
Java 9+ support in tomcat85

Replaced to awk version with full path.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

VVD <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206651|0                           |1
        is obsolete|                            |
 Attachment #206768|                            |maintainer-approval+
              Flags|                            |

--- Comment #11 from VVD <[hidden email]> ---
Created attachment 206768
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206768&action=edit
Java 9+ support in tomcat9 and update to 9.0.24

Replaced to awk version with full path.

Also updated to version 9.0.24:
http://tomcat.apache.org/tomcat-9.0-doc/changelog.html#Tomcat_9.0.24_(markt)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

VVD <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(vvd@un |maintainer-feedback+
                   |islabs.com)                 |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

Walter Schwarzenfeld <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #12 from Walter Schwarzenfeld <[hidden email]> ---
*** Bug 238067 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 239892] www/tomcat9: Support Java 9+

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239892

Greg Lewis <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[hidden email]      |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"