[Bug 240445] ports-mgmt/portlint: PYQT-related false positives

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Bug 240445] ports-mgmt/portlint: PYQT-related false positives

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240445

            Bug ID: 240445
           Summary: ports-mgmt/portlint: PYQT-related false positives
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
          Assignee: [hidden email]
             Flags: maintainer-feedback?([hidden email])
 Attachment #207325 maintainer-approval?
             Flags:

Created attachment 207325
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207325&action=edit
Patch

Hi,

portlint gives false positives about PYQT related variables. This can be seen
with the following.
$ ( cd /usr/ports/graphics/py-traitsui ; portlint -Ca )
WARN: Makefile: When USES=pyqt:5 is defined, you must also define USE_PYQT=xxxx
0 fatal errors and 1 warning found.

A discussion can found at https://reviews.freebsd.org/D21229 .

I propose a patch adding USE_PYQT to @varlist and checking $makevar if static
text analysis does not find the variable. This fixes the bug for me, but you
better carefully test the patch, since I do not use Perl myself.

The patch also bumps the port version, sorry if that disturbs...

QA:
port test : OK
poudriere : OK
portlint -Ca: OK

Vladimir

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"