[Bug 240450] x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 240450] x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240450

            Bug ID: 240450
           Summary: x11-toolkits/p5-Alien-wxWidgets: remove extraneous
                    escapes
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
             Flags: maintainer-feedback?([hidden email])
          Assignee: [hidden email]

Created attachment 207330
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207330&action=edit
svn(1) diff against the ports tree

post-patch phase of this port uses sed to replace 'wx-config with
'${WX_CONFIG:T}. Previously it escaped the ', but this is not necessary in this
context.

Remove the extraneous escape so that it doesn't get passed through to sed(1) as
an escape of an ordinary character. This is important as the patch in bug
#229925 will make such escapes an error to ease transition into a world where
some escaped-ordinaries will be granted a special meaning.

This patch also contains a pkg-plist update to include Config/gtk_3* -- I do
not know if this is correct, but it was needed to get through a poudriere
testport so I've included it.

QA:
 * portlint: OK (minor warnings that should be addressed separately.)
 * testport: OK (poudriere: 12.0-RELEASE, amd64[*])

[*] Only minimal testing done because the nature of the patch would lead to
arch-independent catastrophic meltdown

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-perl
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 240450] x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes

bugzilla-noreply
Bugzilla Automation <[hidden email]> has asked freebsd-perl mailing list
<[hidden email]> for maintainer-feedback:
Bug 240450: x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240450



--- Description ---
post-patch phase of this port uses sed to replace 'wx-config with
'${WX_CONFIG:T}. Previously it escaped the ', but this is not necessary in this
context.

Remove the extraneous escape so that it doesn't get passed through to sed(1) as
an escape of an ordinary character. This is important as the patch in bug
#229925 will make such escapes an error to ease transition into a world where
some escaped-ordinaries will be granted a special meaning.

This patch also contains a pkg-plist update to include Config/gtk_3* -- I do
not know if this is correct, but it was needed to get through a poudriere
testport so I've included it.

QA:
 * portlint: OK (minor warnings that should be addressed separately.)
 * testport: OK (poudriere: 12.0-RELEASE, amd64[*])

[*] Only minimal testing done because the nature of the patch would lead to
arch-independent catastrophic meltdown
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-perl
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240450] x11-toolkits/p5-Alien-wxWidgets: remove extraneous escapes

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240450

Kyle Evans <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
             Blocks|                            |229925


Referenced Bugs:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229925
[Bug 229925] [EXP-RUN] Disallow escaping ordinary characters in regex(3)
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-perl
To unsubscribe, send any mail to "[hidden email]"