[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

            Bug ID: 240883
           Summary: Mk/Uses/php.mk: fix build of all PHP modules when
                    using php74 on GCC architectures
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]

Created attachment 207902
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207902&action=edit
patch

php74 introduced C11 requirement and all optional PHP modules available in the
ports tree need a patch like this:

.include <bsd.port.options.mk>
.if ${FLAVOR} == php74
USES+=compiler:c11
.endif

With over 400 ports that need, it's not feasible to fix. And there will be
php75 (or 80) next year which will require all those ports to be fixed again.

Change php.mk to fix it in one place.

Additionally, fix a typo.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

Piotr Kubaj <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Individual Port(s)          |Ports Framework
           Severity|Affects Only Me             |Affects Many People
                 CC|                            |[hidden email]
           Assignee|[hidden email]      |[hidden email]

--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

Piotr Kubaj <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |maintainer-feedback?(ale@Fr
                   |                            |eeBSD.org), exp-run?
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

Alex Dupre <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(ale@Fr |maintainer-feedback+
                   |eeBSD.org)                  |

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

--- Comment #1 from Piotr Kubaj <[hidden email]> ---
Don't commit it yet, it looks like the ports that I was testing it for were
inheriting compiler:c11 from lang/php74. It doesn't seem to work for ports that
don't.

root@talos:$/usr/ports/security/pecl-mcrypt$ make FLAVOR=php74 -V USES
php:pecl compiler:c11
root@talos:$/usr/ports/security/pecl-mcrypt$ make FLAVOR=php74 -V CC
cc

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

Piotr Kubaj <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207902|0                           |1
        is obsolete|                            |
 Attachment #207931|                            |maintainer-approval?(ale@Fr
              Flags|                            |eeBSD.org)

--- Comment #2 from Piotr Kubaj <[hidden email]> ---
Created attachment 207931
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207931&action=edit
v2

This seems to work, but powerpc* switches to LLVM when LLVM9 is merged to head,
so it will need some modifications in the coming weeks.

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

--- Comment #3 from Alex Dupre <[hidden email]> ---
Why the previous patch doesn't work and why do we not have USE_GCC for those
archs in lang/php74 Makefile?

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 240883] Mk/Uses/php.mk: fix build of all PHP modules when using php74 on GCC architectures

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240883

--- Comment #4 from Piotr Kubaj <[hidden email]> ---
(In reply to Alex Dupre from comment #3)
"Why the previous patch doesn't work"
It's probably because USES is added too late, it should be in the Makefile
instead. When added to Mk/Uses, USES value is actually changed, but CC doesn't
change.

Look at Mk/Uses/qt-dist.mk, it's done the same way.

"why do we not have USE_GCC for those archs in lang/php74 Makefile"
We do have USES=compiler:c11 (which sets USE_GCC on GCC platforms), but that
only works for php74 and the ports that include lang/php74/Makefile (all
*/php74-* ports, e.g. archivers/php74-bz2).

--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"