[Bug 245799] [patch] math/gnumeric Allow build with python3

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] [patch] math/gnumeric Allow build with python3

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

            Bug ID: 245799
           Summary: [patch] math/gnumeric Allow build with python3
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: [hidden email]
          Reporter: [hidden email]
          Assignee: [hidden email]
             Flags: maintainer-feedback?([hidden email])

Created attachment 213649
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=213649&action=edit
Patch to allow math/gnumeric to build with python3 as default

math/gnumeric has been scheduled for deletion due to the port's requirement for
python2, but gnumeric no longer requires python2. The only issue was that the
port tried to compile the python plugins that are no longer built when python2
is not found.

The attached patch simply removes the post-install compilation of the
non-existent files and updates pkg-plist accordingly. No actual changes to the
build are needed or made. If, at some point in the future, the plugins are
updated to python3, the post-install compile could be re-implemented.

The patch should be updated to conditionally run post-install on systems where
python2 is default. The pkg-plist would need to be fixed and I don't know how
to do that.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

maintainer-feedback requested: [Bug 245799] [patch] math/gnumeric Allow build with python3

bugzilla-noreply
Bugzilla Automation <[hidden email]> has asked freebsd-gnome mailing list
<[hidden email]> for maintainer-feedback:
Bug 245799: [patch] math/gnumeric Allow build with python3
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799



--- Description ---
math/gnumeric has been scheduled for deletion due to the port's requirement for
python2, but gnumeric no longer requires python2. The only issue was that the
port tried to compile the python plugins that are no longer built when python2
is not found.

The attached patch simply removes the post-install compilation of the
non-existent files and updates pkg-plist accordingly. No actual changes to the
build are needed or made. If, at some point in the future, the plugins are
updated to python3, the post-install compile could be re-implemented.

The patch should be updated to conditionally run post-install on systems where
python2 is default. The pkg-plist would need to be fixed and I don't know how
to do that.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] [patch] math/gnumeric Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

Thierry Thomas <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email],
                   |                            |[hidden email]

--- Comment #1 from Thierry Thomas <[hidden email]> ---
Adding koobs: is there a policy about "compile all" with Pyton-3?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] [patch] math/gnumeric Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

--- Comment #2 from [hidden email] ---
(In reply to Thierry Thomas from comment #1)
I have looked more closely and there is no benefit to running compileall in
gnumeric. Since the only files compiled are the plugins that are not built with
python3, it simply should be removed when PYTHON_DEFAULT < 3.

Trivial to do this. I have not figured out the magic to get the pkg-plist
right, but I have spent little time on it as we moved today and have been busy
getting ready (and now, getting back to "normal"). I will try a couple of
htings as soon as I have a bit of time, but it is probably trivial for a lot of
porters.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] math/gnumeric: Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[patch] math/gnumeric Allow |math/gnumeric: Allow build
                   |build with python3          |with python3

--- Comment #3 from Kubilay Kocak <[hidden email]> ---
(In reply to Thierry Thomas from comment #1)

Just that it should be:

- A standard and deterministic invocation (see other ports uses)
- The all files (pyo, pyc*, etc) are created (invocation args affect this)
- That all files from that invocation are added to the pkg-plist

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] math/gnumeric: Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

Kubilay Kocak <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-qa
             Status|New                         |Open

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] math/gnumeric: Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

--- Comment #4 from [hidden email] ---
Just to be clear, when PYTHON_DEFAULT is 3.x, there are no python plugins
installed. If you attempt to run compileall-py, it will fail and the the port
will not be installed. If PYTHON_DEFAULT is 2.7, compileall.py will compile the
three plugins and they will be installed.

So running the post-install section should only be run for and the compiled
files should only be added to the packing list for python-2.7.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] math/gnumeric: Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213649|0                           |1
        is obsolete|                            |
 Attachment #215625|                            |maintainer-approval?
              Flags|                            |

--- Comment #5 from [hidden email] ---
Created attachment 215625
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215625&action=edit
Updated patch to remove depenency on Python2

This one seems to be going nowhere. Let's just stop supporting Python2 and move
on. This patch updated gnumeric to Python3 only. It builds are upstream
recommends, without the plugins that require Python2. Upstream says that the
plugins may be re-introduced when/if they are fixed, but it does not sound
likely any time soon.

Python2 is dead. Lat's move on.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] math/gnumeric: Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

--- Comment #6 from Jan Beich <[hidden email]> ---
Created attachment 215635
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215635&action=edit
Add Python 3 flavor

Why not expose Python 3 support as a separate non-default flavor (a la ports
r538844)?

Disclaimer: I've never used this port.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] math/gnumeric: Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

--- Comment #7 from Jan Beich <[hidden email]> ---
Created attachment 215636
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215636&action=edit
Optionalize Python support

Or make Python loader/plugins optional, disabled by default unless
DEFAULT_VERSIONS += python=2.7

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 245799] math/gnumeric: Allow build with python3

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245799

--- Comment #8 from [hidden email] ---
(In reply to Jan Beich from comment #6)
Python is NOT optional for this port. While the plugins are not Python3
compatible, the port itself also uses Python and all of those files already
support Python3.

I really think that it is silly to maintain the ability to use Python2. Very
few ports require it and some simply don't support it any longer. It seems
unlikely that anyone using Gnumeric, an Excel like spreadsheet, will not
already have Python3 installed.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gnome
To unsubscribe, send any mail to "[hidden email]"