[Bug 246697] bectl.c: sync help text to man page

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

            Bug ID: 246697
           Summary: bectl.c: sync help text to man page
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: [hidden email]
          Reporter: [hidden email]

Created attachment 214812
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=214812&action=edit
bectl help text fixes

Sync the bectl help text with the man page synopsis.

Notably, the "-o" option of "bectl destroy" was missing.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] [patch] bectl.c: sync help text to man page

bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

Jimmy Olgeni <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|bectl.c: sync help text to  |[patch] bectl.c: sync help
                   |man page                    |text to man page

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

Mark Linimon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
            Summary|[patch] bectl.c: sync help  |bectl.c: sync help text to
                   |text to man page            |man page

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

--- Comment #1 from Kyle Evans <[hidden email]> ---
Mostly LGTM -- there's one change that I don't think I agree with, but it's
wrong in the manpage too (which is the version you changed it to):

> bectl jail [-bU] [{-o key=value | -u key}]...

-b and -U are mutually exclusive options, as they were represented before. We
should also fix the manpage to reflect that (I can follow up with this) and
perhaps make `bectl jail` actually error out. The problem is that the options
are philosophically at odds with each other; one is specifically meant to keep
the jail around and not do anything interactive with it because the caller will
operate on it, while the other implies that the jail+mount should be torn down
before bectl returns.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

Mark Johnston <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open

--- Comment #2 from Mark Johnston <[hidden email]> ---
Part of the proposed patch was committed independently.  Would either of you be
willing to upload a new patch based on comment 1?

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

Robert Wing <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Robert Wing <[hidden email]> ---
https://reviews.freebsd.org/D27482

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

--- Comment #4 from [hidden email] ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=b1ea63e2e3c92d1346af067f5cf609e3e062f8b9

commit b1ea63e2e3c92d1346af067f5cf609e3e062f8b9
Author:     Robert Wing <[hidden email]>
AuthorDate: 2021-01-06 19:38:25 +0000
Commit:     Robert Wing <[hidden email]>
CommitDate: 2021-01-06 19:38:25 +0000

    bectl(8): sync man page and help text

    Sync man page with behavior of bectl(8).

    Sync help text with man page.

    PR:             246697
    Reported by:    olgeni
    Submitted by:   olgeni (with changes)
    Reviewed by:    kevans, olgeni
    Approved by:    kevans (mentor)
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D27482

 sbin/bectl/bectl.8 | 11 +++++------
 sbin/bectl/bectl.c |  9 ++++-----
 2 files changed, 9 insertions(+), 11 deletions(-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

--- Comment #5 from [hidden email] ---
A commit in branch stable/12 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3d3c424eb6e3909f2f7cd318b9a8a1bbb0783705

commit 3d3c424eb6e3909f2f7cd318b9a8a1bbb0783705
Author:     Robert Wing <[hidden email]>
AuthorDate: 2021-01-06 19:38:25 +0000
Commit:     Robert Wing <[hidden email]>
CommitDate: 2021-01-17 09:12:42 +0000

    bectl(8): sync man page and help text

    Sync man page with behavior of bectl(8).

    Sync help text with man page.

    PR:             246697
    Reported by:    olgeni
    Submitted by:   olgeni (with changes)
    Reviewed by:    kevans, olgeni
    Approved by:    kevans (mentor)
    Differential Revision:  https://reviews.freebsd.org/D27482

    (cherry picked from commit b1ea63e2e3c92d1346af067f5cf609e3e062f8b9)

 sbin/bectl/bectl.8 | 11 +++++------
 sbin/bectl/bectl.c |  9 ++++-----
 2 files changed, 9 insertions(+), 11 deletions(-)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

[Bug 246697] bectl.c: sync help text to man page

bugzilla-noreply
In reply to this post by bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246697

Robert Wing <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Open                        |Closed

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[hidden email]"