Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

grahamperrin
My last successful build was of ~56.2.7.1. Build ID, mid-February:

20190213143714

56.2.7.1 no longer builds, and I can't build recently released 56.2.8.

Below: the tail of a log file for 56.2.8. Two patch files were set aside
prior to the build:

$ ls -hl /usr/local/poudriere/ports/default/www/waterfox/files/setaside/
total 18
-rw-r--r--  1 root  wheel   2.1K 17 Mar 13:04 patch-bug1395486
-rw-r--r--  1 root  wheel   801B 17 Mar 13:04 patch-bug1447519
$

Seeing 'servo', I imagine no easy workaround for this, but I'm open to
friendly suggestions :-)

==== tail of
====
/usr/local/poudriere/data/logs/bulk/head-default/2019-03-17_13h16m39s/logs/waterfox-56.2.8.log

    Compiling style_derive v0.0.1
(/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_derive)
warning: use of deprecated item 'core::str::<impl
str>::trim_right_matches': superseded by `trim_end_matches`
    -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_derive/to_css.rs:157:29
     |
157 |     camel_case = camel_case.trim_right_matches('_');
     |                             ^^^^^^^^^^^^^^^^^^
     |
     = note: #[warn(deprecated)] on by default

warning: use of deprecated item 'std::ascii::AsciiExt': use inherent
methods instead
  -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/selectors/attr.rs:7:30
   |
7 | #[allow(unused_imports)] use std::ascii::AsciiExt;
   |                              ^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(deprecated)] on by default

warning: use of deprecated item 'std::ascii::AsciiExt': use inherent
methods instead
   -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/selectors/parser.rs:16:30
    |
16 | #[allow(unused_imports)] use std::ascii::AsciiExt;
    |                              ^^^^^^^^^^^^^^^^^^^^

    Compiling style_traits v0.0.1
(/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits)
warning: use of deprecated item 'std::ascii::AsciiExt': use inherent
methods instead
   -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/viewport.rs:10:30
    |
10 | #[allow(unused_imports)] use std::ascii::AsciiExt;
    |                              ^^^^^^^^^^^^^^^^^^^^
    |
    = note: #[warn(deprecated)] on by default

error: missing documentation for macro
    -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/values.rs:341:1
     |
341 | macro_rules! define_css_keyword_enum {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
note: lint level defined here
    -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/lib.rs:12:22
     |
12  | #![deny(unsafe_code, missing_docs)]
     |                      ^^^^^^^^^^^^

error: missing documentation for macro
    -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/values.rs:385:1
     |
385 | macro_rules! __define_css_keyword_enum__add_optional_traits {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: missing documentation for macro
    -->
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/values.rs:394:1
     |
394 | macro_rules! __define_css_keyword_enum__actual {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 3 previous errors

error: Could not compile `style_traits`.
warning: build failed, waiting for other jobs to finish...
error: build failed
gmake[4]: ***
[/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/config/rules.mk:999:
force-cargo-library-build] Error 101
gmake[4]: Leaving directory
'/wrkdirs/usr/ports/www/waterfox/work/.build/toolkit/library/rust'
gmake[3]: ***
[/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/config/recurse.mk:73:
toolkit/library/rust/target] Error 2
gmake[3]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
gmake[2]: ***
[/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/config/recurse.mk:33:
compile] Error 2
gmake[2]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
gmake[1]: ***
[/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/config/rules.mk:453:
all] Error 2
gmake[1]: Leaving directory '/wrkdirs/usr/ports/www/waterfox/work/.build'
*** Error code 1

Stop.
make: stopped in /usr/ports/www/waterfox
=>> Cleaning up wrkdir
===>  Cleaning for waterfox-56.2.8
build of www/waterfox | waterfox-56.2.8 ended at Sun Mar 17 13:46:41 GMT
2019
build time: 00:29:46
!!! build failure encountered !!!
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

Jan Beich-5
Graham Perrin <[hidden email]> writes:

> error: missing documentation for macro
>    -->
> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/values.rs:341:1
>     |
> 341 | macro_rules! define_css_keyword_enum {
>     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>     |
> note: lint level defined here
>    -->
> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/lib.rs:12:22
>     |
> 12  | #![deny(unsafe_code, missing_docs)]
>     |                      ^^^^^^^^^^^^

Looks like a regression from Rust 1.33 update.

Either remove missing_docs from #![deny(...)] lines (or lines themselves)
for each one that triggers error (no need to bother with unused ones) or
add MOZ_OPTIONS+=--disable-stylo to Makefile.local.

www/firefox-esr et al. simply backported upstream fixes for warnings to
avoid having to maintain workarounds forever. Rebasing those against
very old Stylo code isn't worth the effort.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

freebsd-gecko mailing list
On 17/03/2019 12:25, Jan Beich wrote:

> Graham Perrin writes:
>
>> error: missing documentation for macro
>>    -->
>> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/values.rs:341:1
>>     |
>> 341 | macro_rules! define_css_keyword_enum {
>>     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>     |
>> note: lint level defined here
>>    -->
>> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/servo/components/style_traits/lib.rs:12:22
>>     |
>> 12  | #![deny(unsafe_code, missing_docs)]
>>     |                      ^^^^^^^^^^^^
>
> Looks like a regression from Rust 1.33 update.
>
> Either remove missing_docs from #![deny(...)] lines (or lines themselves)
> for each one that triggers error (no need to bother with unused ones) or
> add MOZ_OPTIONS+=--disable-stylo to Makefile.local.
>
> www/firefox-esr et al. simply backported upstream fixes for warnings to
> avoid having to maintain workarounds forever. Rebasing those against
> very old Stylo code isn't worth the effort.
>
I simply followed the tip given in Mozilla bug 1521249 (remove
`#![deny(missing_docs)]`), and have been running with it since we
updated our lang/rust to 1.33:
https://bugzilla.mozilla.org/show_bug.cgi?id=1521249#c36

Mozilla upstream are concerned about keeping compatibility with older
rust, especially for their ESR. Since we only ship the latest version of
rust at a time, we don't have to worry about that sort of compatibility,
so backport away.

--
Charlie Li
…nope, still don't have an exit line.

(This email address is for mailing list use; replace local-part with
vishwin for off-list communication if possible)


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

grahamperrin
On 17/03/2019 19:54, Charlie Li wrote:

 > On 17/03/2019 12:25, Jan Beich wrote:
 >
 >> …
 >>
 >> Looks like a regression from Rust 1.33 update.
 >>
 >> Either remove missing_docs from #![deny(...)] lines (or lines
themselves)
 >> for each one that triggers error (no need to bother with unused ones) or
 >> add MOZ_OPTIONS+=--disable-stylo to Makefile.local.
 >>
 >> …
 >
 > I simply followed the tip given in Mozilla bug 1521249 (remove
 > `#![deny(missing_docs)]`), and have been running with it since we
 > updated our lang/rust to 1.33:
 > https://bugzilla.mozilla.org/show_bug.cgi?id=1521249#c36
 >
 > …

Thank you both.

In my fork: <https://github.com/grahamperrin/Waterfox/pull/7/files> – at
a glance, does that look OK?

I'm unsure about
<https://github.com/grahamperrin/Waterfox/pull/7/files#diff-df8dc4c48927e0bc43931d04bb5b9d9aR161>,
should that line be left as was?

  #[deny(missing_docs)]

(No exclamation mark.)
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

Jan Beich-5
Graham Perrin <[hidden email]> writes:

> On 17/03/2019 19:54, Charlie Li wrote:
>
>> On 17/03/2019 12:25, Jan Beich wrote:
>>
>>> …
>>>
>>> Looks like a regression from Rust 1.33 update.
>>>
>>> Either remove missing_docs from #![deny(...)] lines (or lines
> themselves)
>>> for each one that triggers error (no need to bother with unused ones) or
>>> add MOZ_OPTIONS+=--disable-stylo to Makefile.local.
>>>
>>> …
>>
>> I simply followed the tip given in Mozilla bug 1521249 (remove
>> `#![deny(missing_docs)]`), and have been running with it since we
>> updated our lang/rust to 1.33:
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1521249#c36
>>

#![deny(missing_docs)] should probably be killed in favor of -Dwarnings
after https://bugzilla.mozilla.org/show_bug.cgi?id=1513009

It's usually a waste of time to fix doc-related warnigs on release branches.
Rust compiler upgrades just make this more obvious.

>
> Thank you both.
>
> In my fork: <https://github.com/grahamperrin/Waterfox/pull/7/files> –
> at a glance, does that look OK?
>
> I'm unsure about
> <https://github.com/grahamperrin/Waterfox/pull/7/files#diff-df8dc4c48927e0bc43931d04bb5b9d9aR161>,
> should that line be left as was?
>
>  #[deny(missing_docs)]
>
> (No exclamation mark.)

If the line doesn't break build, leave it as is.
See also https://doc.rust-lang.org/reference/attributes.html

In general, try to document error you're fixing or working around in the
commit message as the rationale. And discussions like this one are only
useful to reference as meta information in PR description, not in commits.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

grahamperrin
In reply to this post by Jan Beich-5
On 17/03/2019 16:25, Jan Beich wrote:

 > … or add MOZ_OPTIONS+=--disable-stylo to Makefile.local. …

I tried that,


checking for the target C compiler... /usr/local/bin/clang80
checking whether the target C compiler can be used... yes
Traceback (most recent call last):
   File
"/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/configure.py",
line 124, in <module>
     sys.exit(main(sys.argv))
   File
"/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/configure.py",
line 29, in main
     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
   File
"/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/python/mozbuild/mozbuild/configure/__init__.py",
line 407, in run
     self._value_for(option)
   File
"/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/python/mozbuild/mozbuild/configure/__init__.py",
line 475, in _value_for
     return self._value_for_option(obj)
   File
"/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/python/mozbuild/mozbuild/util.py",
line 925, in method_call
     cache[args] = self.func(instance, *args)
   File
"/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/python/mozbuild/mozbuild/configure/__init__.py",
line 540, in _value_for_option
     % option_string.split('=', 1)[0])
mozbuild.configure.options.InvalidOptionError: LLVM_CONFIG is not
available in this configuration
===>  Script "configure" failed unexpectedly.


----

I can't figure out where to `unset LLVM_CONFIG`
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

grahamperrin
In reply to this post by Jan Beich-5
On 17/03/2019 16:25, Jan Beich wrote:

 > … or add MOZ_OPTIONS+=--disable-stylo to Makefile.local. …

Thanks again. This was one of a handful of keys to success.

----

One thing puzzles me. I found it necessary to _manually_
remove the LLVM_CONFIG=llvm-config80 line from:

/usr/ports/www/waterfox/work/Waterfox-56.2.8/.mozconfig

The puzzle:

- I can not understand what causes the LLVM-related line
   to appear in that context.

I guess, it's written as part of an Autoconf routine but I can't get my
head around it.

If I can gain an understanding, then I might find a way to build with
poudriere …
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

Jan Beich-5
Graham Perrin <[hidden email]> writes:

> On 17/03/2019 16:25, Jan Beich wrote:
>
>> … or add MOZ_OPTIONS+=--disable-stylo to Makefile.local. …
>
> Thanks again. This was one of a handful of keys to success.
>
> ----
>
> One thing puzzles me. I found it necessary to _manually_
> remove the LLVM_CONFIG=llvm-config80 line from:
>
> /usr/ports/www/waterfox/work/Waterfox-56.2.8/.mozconfig

LLVM_CONFIG is added to mozconfig by Mk/bsd.gecko.mk in order to force a
specific version of devel/llvm*. Try the following instead:

Index: Mk/bsd.gecko.mk
===================================================================
--- Mk/bsd.gecko.mk (revision 496825)
+++ Mk/bsd.gecko.mk (working copy)
@@ -92,7 +92,9 @@ CONFIGURE_OUTSOURCE= yes
 
 BUNDLE_LIBS= yes
 
-.if ${MOZILLA_VER:R:R} >= 56
+.if ${MOZILLA} == waterfox
+MOZ_OPTIONS+= --disable-stylo
+.elif ${MOZILLA_VER:R:R} >= 56
 BUILD_DEPENDS+= llvm${LLVM_DEFAULT}>0:devel/llvm${LLVM_DEFAULT}
 MOZ_EXPORT+= LLVM_CONFIG=llvm-config${LLVM_DEFAULT}
 # Require newer Clang than what's in base system unless user opted out
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

grahamperrin
On 05/04/2019 00:22, Jan Beich wrote:



 > LLVM_CONFIG is added to mozconfig by Mk/bsd.gecko.mk in order to
 > force a > specific version of devel/llvm*. Try the following instead:
 >
 > Index: Mk/bsd.gecko.mk
 > ===================================================================
 > --- Mk/bsd.gecko.mk    (revision 496825)
 > +++ Mk/bsd.gecko.mk    (working copy)
 > @@ -92,7 +92,9 @@ CONFIGURE_OUTSOURCE=    yes
 >
 >  BUNDLE_LIBS=    yes
 >
 > -.if ${MOZILLA_VER:R:R} >= 56
 > +.if ${MOZILLA} == waterfox
 > +MOZ_OPTIONS+=    --disable-stylo
 > +.elif ${MOZILLA_VER:R:R} >= 56
 >  BUILD_DEPENDS+=  llvm${LLVM_DEFAULT}>0:devel/llvm${LLVM_DEFAULT}
 >  MOZ_EXPORT+=    LLVM_CONFIG=llvm-config${LLVM_DEFAULT}
 >  # Require newer Clang than what's in base system unless user opted out

Failure, around two hours into the build:

---- … ----
/wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:858:17:
error: no member named 'frame_flags' in 'vpx_svc_ref_frame_config'
         sf_conf.frame_flags[layer_idx] = layer_flags;
         ~~~~~~~ ^
1 error generated.
---- … ----

A little more conext: <https://s.put.re/qHF1xihd.txt>
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro

Jan Beich-5
Graham Perrin <[hidden email]> writes:

> On 05/04/2019 00:22, Jan Beich wrote:
>
> …
>
>> LLVM_CONFIG is added to mozconfig by Mk/bsd.gecko.mk in order to
>> force a > specific version of devel/llvm*. Try the following instead:
>>
>> Index: Mk/bsd.gecko.mk
>> ===================================================================
>> --- Mk/bsd.gecko.mk    (revision 496825)
>> +++ Mk/bsd.gecko.mk    (working copy)
>> @@ -92,7 +92,9 @@ CONFIGURE_OUTSOURCE=    yes
>>
>>  BUNDLE_LIBS=    yes
>>
>> -.if ${MOZILLA_VER:R:R} >= 56
>> +.if ${MOZILLA} == waterfox
>> +MOZ_OPTIONS+=    --disable-stylo
>> +.elif ${MOZILLA_VER:R:R} >= 56
>>  BUILD_DEPENDS+=  llvm${LLVM_DEFAULT}>0:devel/llvm${LLVM_DEFAULT}
>>  MOZ_EXPORT+=    LLVM_CONFIG=llvm-config${LLVM_DEFAULT}
>>  # Require newer Clang than what's in base system unless user opted out
>
> Failure, around two hours into the build:
>
> ---- … ----
> /wrkdirs/usr/ports/www/waterfox/work/Waterfox-56.2.8/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc:858:17:
> error: no member named 'frame_flags' in 'vpx_svc_ref_frame_config'
>         sf_conf.frame_flags[layer_idx] = layer_flags;
>         ~~~~~~~ ^
> 1 error generated.

Did you forget to pick up USE_MOZILLA += -vpx from r492305? That should
omit --with-system-libvpx. Alternatively, pass --disable-webrtc but that
may break some sites.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Waterfox 56.2.8 built with poudriere (was: Building (deleted) Waterfox 56.2.8: error: missing documentation for macro)

grahamperrin
On 05/04/2019 11:15, Jan Beich wrote:

 > … Did you forget to pick up USE_MOZILLA += -vpx from r492305? …

Yes! Forgotten. Thanks for the reminder.

Good now. Summarised:

<https://www.reddit.com/comments/9pocgm/-/ek9or90/>
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-gecko
To unsubscribe, send any mail to "[hidden email]"