Commit privileges and branching

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Commit privileges and branching

Lakhan Shiva
Hi,

I would like to start working on converting PCI drivers that already have a
table but font have a MODULE_PNP_INFO. I would like to know more about the
branching strategy and the process to check in first piece of code. I am
uising FreeBSD VM current image. I will be using SVN for checking out and
checking in code from the VM.

thanks,
Lakhan Kamireddy.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Commit privileges and branching

Mark Saad-5

Lakhan
   Rule of thumb here is ; first do some of the work and submit a patch . This patch would be on the FreeBSD head branch in svn. See svnlite co svn://svn.freebsd.org/base/head and work from there . Commit access to FreeBSD is not handed out without showing you can do the work first . Also I would look into who is the maintainer of this code is currently; and reach out to them with your patches when ready.


---
Mark Saad | [hidden email]

> On Mar 27, 2018, at 12:42 PM, Lakhan Shiva <[hidden email]> wrote:
>
> Hi,
>
> I would like to start working on converting PCI drivers that already have a
> table but font have a MODULE_PNP_INFO. I would like to know more about the
> branching strategy and the process to check in first piece of code. I am
> uising FreeBSD VM current image. I will be using SVN for checking out and
> checking in code from the VM.
>
> thanks,
> Lakhan Kamireddy.
> _______________________________________________
> [hidden email] mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
> To unsubscribe, send any mail to "[hidden email]"
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Commit privileges and branching

Warner Losh
In reply to this post by Lakhan Shiva
On Tue, Mar 27, 2018 at 9:42 AM, Lakhan Shiva <[hidden email]> wrote:

> Hi,
>
> I would like to start working on converting PCI drivers that already have a
> table but font have a MODULE_PNP_INFO. I would like to know more about the
> branching strategy and the process to check in first piece of code. I am
> uising FreeBSD VM current image. I will be using SVN for checking out and
> checking in code from the VM.
>

There's two paths forward for you.

If you are selected for GSoC, you'll have our gsoc svn repo available.

The other option is to fork from http://www.github.org/freebsd/freebsd
using git.

The way that commits normally land in the FreeBSD is that some committer
will push them in with a tag saying that you'd submitted it and when
there's enough you'd get a commit bit of all has gone well.

If you're doing GSoC, then you and your mentor would work this out.

Warner
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Commit privileges and branching

Lakhan Shiva
Hi,

I have made a pull request as suggested.
https://github.com/freebsd/freebsd/pull/135

In this I have added the PNP info for the puc driver.

Please review and comment, for a possible merge.

Thanks,
Lakhan

On Wed, Mar 28, 2018 at 2:15 AM, Warner Losh <[hidden email]> wrote:

>
>
> On Tue, Mar 27, 2018 at 9:42 AM, Lakhan Shiva <[hidden email]>
> wrote:
>
>> Hi,
>>
>> I would like to start working on converting PCI drivers that already have
>> a
>> table but font have a MODULE_PNP_INFO. I would like to know more about the
>> branching strategy and the process to check in first piece of code. I am
>> uising FreeBSD VM current image. I will be using SVN for checking out and
>> checking in code from the VM.
>>
>
> There's two paths forward for you.
>
> If you are selected for GSoC, you'll have our gsoc svn repo available.
>
> The other option is to fork from http://www.github.org/freebsd/freebsd
> using git.
>
> The way that commits normally land in the FreeBSD is that some committer
> will push them in with a tag saying that you'd submitted it and when
> there's enough you'd get a commit bit of all has gone well.
>
> If you're doing GSoC, then you and your mentor would work this out.
>
> Warner
>
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: Commit privileges and branching

Warner Losh
Thanks! I'll comment there.

Warner

On Wed, Mar 28, 2018 at 8:18 AM, Lakhan Shiva <[hidden email]> wrote:

> Hi,
>
> I have made a pull request as suggested.
> https://github.com/freebsd/freebsd/pull/135
>
> In this I have added the PNP info for the puc driver.
>
> Please review and comment, for a possible merge.
>
> Thanks,
> Lakhan
>
> On Wed, Mar 28, 2018 at 2:15 AM, Warner Losh <[hidden email]> wrote:
>
>>
>>
>> On Tue, Mar 27, 2018 at 9:42 AM, Lakhan Shiva <[hidden email]>
>> wrote:
>>
>>> Hi,
>>>
>>> I would like to start working on converting PCI drivers that already
>>> have a
>>> table but font have a MODULE_PNP_INFO. I would like to know more about
>>> the
>>> branching strategy and the process to check in first piece of code. I am
>>> uising FreeBSD VM current image. I will be using SVN for checking out and
>>> checking in code from the VM.
>>>
>>
>> There's two paths forward for you.
>>
>> If you are selected for GSoC, you'll have our gsoc svn repo available.
>>
>> The other option is to fork from http://www.github.org/freebsd/freebsd
>> using git.
>>
>> The way that commits normally land in the FreeBSD is that some committer
>> will push them in with a tag saying that you'd submitted it and when
>> there's enough you'd get a commit bit of all has gone well.
>>
>> If you're doing GSoC, then you and your mentor would work this out.
>>
>> Warner
>>
>
>
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "[hidden email]"