drm-legacy is broken, again

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

drm-legacy is broken, again

Steve Kargl
Just updated /usr/src to top of tree.

Trying to update drm-legacy port.  After
a failed 'make' in /usr/ports/drm-legacy

% make |& tee drm.txt
% tail drm.txt

===> drm2/drm2 (all)
Warning: Object directory not changed from original /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/drm2/drm2
cc  -O2 -pipe -march=bdver2 -fno-strict-aliasing -march=bdver2  -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/drm2/../src/ -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include     -MD  -MF.depend.drm_crtc.o -MTdrm_crtc.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno
 -address-of-packed-member  -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c -o drm_crtc.o
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1128:21: error: use of undeclared identifier 'USHRT_MAX'
        if (in->hdisplay > USHRT_MAX || in->hsync_start > USHRT_MAX ||
                           ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1128:52: error: use of undeclared identifier 'USHRT_MAX'
        if (in->hdisplay > USHRT_MAX || in->hsync_start > USHRT_MAX ||
                                                          ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1129:23: error: use of undeclared identifier 'USHRT_MAX'
             in->hsync_end > USHRT_MAX || in->htotal > USHRT_MAX ||
                             ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1129:49: error: use of undeclared identifier 'USHRT_MAX'
             in->hsync_end > USHRT_MAX || in->htotal > USHRT_MAX ||
                                                       ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1130:19: error: use of undeclared identifier 'USHRT_MAX'
             in->hskew > USHRT_MAX || in->vdisplay > USHRT_MAX ||
                         ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1130:47: error: use of undeclared identifier 'USHRT_MAX'
             in->hskew > USHRT_MAX || in->vdisplay > USHRT_MAX ||
                                                     ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1131:25: error: use of undeclared identifier 'USHRT_MAX'
             in->vsync_start > USHRT_MAX || in->vsync_end > USHRT_MAX ||
                               ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1131:54: error: use of undeclared identifier 'USHRT_MAX'
             in->vsync_start > USHRT_MAX || in->vsync_end > USHRT_MAX ||
                                                            ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1132:20: error: use of undeclared identifier 'USHRT_MAX'
             in->vtotal > USHRT_MAX || in->vscan > USHRT_MAX)
                          ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1132:45: error: use of undeclared identifier 'USHRT_MAX'
             in->vtotal > USHRT_MAX || in->vscan > USHRT_MAX)
                                                   ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1170:18: error: use of undeclared identifier 'INT_MAX'
        if (in->clock > INT_MAX || in->vrefresh > INT_MAX)
                        ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1170:44: error: use of undeclared identifier 'INT_MAX'
        if (in->clock > INT_MAX || in->vrefresh > INT_MAX)
                                                  ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1840:26: error: use of undeclared identifier 'INT_MAX'
        if (plane_req->crtc_w > INT_MAX ||
                                ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1841:26: error: use of undeclared identifier 'INT_MAX'
            plane_req->crtc_x > INT_MAX - (int32_t) plane_req->crtc_w ||
                                ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1842:26: error: use of undeclared identifier 'INT_MAX'
            plane_req->crtc_h > INT_MAX ||
                                ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1843:26: error: use of undeclared identifier 'INT_MAX'
            plane_req->crtc_y > INT_MAX - (int32_t) plane_req->crtc_h) {
                                ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1903:20: error: use of undeclared identifier 'INT_MAX'
        if (crtc_req->x > INT_MAX || crtc_req->y > INT_MAX)
                          ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:1903:45: error: use of undeclared identifier 'INT_MAX'
        if (crtc_req->x > INT_MAX || crtc_req->y > INT_MAX)
                                                   ^
/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/src/dev/drm2/drm_crtc.c:2297:32: error: use of undeclared identifier 'UINT_MAX'
                if ((uint64_t) width * cpp > UINT_MAX)
                                             ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
*** Error code 1

Stop.
make[4]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/drm2/drm2
*** Error code 1

Stop.
make[3]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b/drm2
*** Error code 1

Stop.
make[2]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-990f64b
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/graphics/drm-legacy-kmod
*** Error code 1

Stop.
make: stopped in /usr/ports/graphics/drm-legacy-kmod

--
Steve
20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4
20161221 https://www.youtube.com/watch?v=IbCHE-hONow
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-x11
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: drm-legacy is broken, again

Mark Johnston-2
On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote:
> Just updated /usr/src to top of tree.
>
> Trying to update drm-legacy port.  After
> a failed 'make' in /usr/ports/drm-legacy

The patch below should fix it.  drm was relying on refcount.h including
limits.h.

diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h
index 3af7ad1..7cbd8db 100644
--- a/src/dev/drm2/drmP.h
+++ b/src/dev/drm2/drmP.h
@@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$");
 
 #include <sys/param.h>
 #include <sys/queue.h>
+#include <sys/limits.h>
 #include <sys/malloc.h>
 #include <sys/kernel.h>
 #include <sys/ktr.h>
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-x11
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: drm-legacy is broken, again

Steve Kargl
On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote:

> On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote:
> > Just updated /usr/src to top of tree.
> >
> > Trying to update drm-legacy port.  After
> > a failed 'make' in /usr/ports/drm-legacy
>
> The patch below should fix it.  drm was relying on refcount.h including
> limits.h.
>
> diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h
> index 3af7ad1..7cbd8db 100644
> --- a/src/dev/drm2/drmP.h
> +++ b/src/dev/drm2/drmP.h
> @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$");
>  
>  #include <sys/param.h>
>  #include <sys/queue.h>
> +#include <sys/limits.h>
>  #include <sys/malloc.h>
>  #include <sys/kernel.h>
>  #include <sys/ktr.h>

Thanks for the quick response.  I had recalled someone
has/had been undoing some header pollution changes,
but the individual names escaped me.  

--
Steve
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-x11
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: drm-legacy is broken, again

Mark Johnston-2
On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote:

> On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote:
> > On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote:
> > > Just updated /usr/src to top of tree.
> > >
> > > Trying to update drm-legacy port.  After
> > > a failed 'make' in /usr/ports/drm-legacy
> >
> > The patch below should fix it.  drm was relying on refcount.h including
> > limits.h.
> >
> > diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h
> > index 3af7ad1..7cbd8db 100644
> > --- a/src/dev/drm2/drmP.h
> > +++ b/src/dev/drm2/drmP.h
> > @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$");
> >  
> >  #include <sys/param.h>
> >  #include <sys/queue.h>
> > +#include <sys/limits.h>
> >  #include <sys/malloc.h>
> >  #include <sys/kernel.h>
> >  #include <sys/ktr.h>
>
> Thanks for the quick response.  I had recalled someone
> has/had been undoing some header pollution changes,
> but the individual names escaped me.  

I reproduced the issue and submitted a PR:
https://github.com/FreeBSDDesktop/drm-legacy/pull/13
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-x11
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: drm-legacy is broken, again

Steve Kargl
On Thu, Aug 01, 2019 at 03:31:15PM -0400, Mark Johnston wrote:

> On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote:
> > On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote:
> > > On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote:
> > > > Just updated /usr/src to top of tree.
> > > >
> > > > Trying to update drm-legacy port.  After
> > > > a failed 'make' in /usr/ports/drm-legacy
> > >
> > > The patch below should fix it.  drm was relying on refcount.h including
> > > limits.h.
> > >
> > > diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h
> > > index 3af7ad1..7cbd8db 100644
> > > --- a/src/dev/drm2/drmP.h
> > > +++ b/src/dev/drm2/drmP.h
> > > @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$");
> > >  
> > >  #include <sys/param.h>
> > >  #include <sys/queue.h>
> > > +#include <sys/limits.h>
> > >  #include <sys/malloc.h>
> > >  #include <sys/kernel.h>
> > >  #include <sys/ktr.h>
> >
> > Thanks for the quick response.  I had recalled someone
> > has/had been undoing some header pollution changes,
> > but the individual names escaped me.  
>
> I reproduced the issue and submitted a PR:
> https://github.com/FreeBSDDesktop/drm-legacy/pull/13


Thanks for that, too.  I'm not in a position to
submit a PR as my mouse has gone missing under
Xorg.

--
Steve
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-x11
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: drm-legacy is broken, again

Niclas Zeising-6
On 2019-08-01 21:42, Steve Kargl wrote:

> On Thu, Aug 01, 2019 at 03:31:15PM -0400, Mark Johnston wrote:
>> On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote:
>>> On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote:
>>>> On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote:
>>>>> Just updated /usr/src to top of tree.
>>>>>
>>>>> Trying to update drm-legacy port.  After
>>>>> a failed 'make' in /usr/ports/drm-legacy
>>>>
>>>> The patch below should fix it.  drm was relying on refcount.h including
>>>> limits.h.
>>>>
>>>> diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h
>>>> index 3af7ad1..7cbd8db 100644
>>>> --- a/src/dev/drm2/drmP.h
>>>> +++ b/src/dev/drm2/drmP.h
>>>> @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$");
>>>>  
>>>>   #include <sys/param.h>
>>>>   #include <sys/queue.h>
>>>> +#include <sys/limits.h>
>>>>   #include <sys/malloc.h>
>>>>   #include <sys/kernel.h>
>>>>   #include <sys/ktr.h>
>>>
>>> Thanks for the quick response.  I had recalled someone
>>> has/had been undoing some header pollution changes,
>>> but the individual names escaped me.
>>
>> I reproduced the issue and submitted a PR:
>> https://github.com/FreeBSDDesktop/drm-legacy/pull/13
>
>
> Thanks for that, too.  I'm not in a position to
> submit a PR as my mouse has gone missing under
> Xorg.
>

Port has been updated:
https://svnweb.freebsd.org/changeset/ports/507828
Regards
--
Niclas Zeising
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-x11
To unsubscribe, send any mail to "[hidden email]"