ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

Jan Beich-2

>Number:         168311
>Category:       ports
>Synopsis:       [patch] sysutils/uhidd: unbreak after yacc update in r235723
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:      
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 24 17:20:02 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
>How-To-Repeat:
$ make
clang -O2 -pipe -I. -I/usr/ports/sysutils/uhidd/work/uhidd-0.2.0/uhidd -g -fno-omit-frame-pointer -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c parser.c
parser.y:214:2: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror]
        exit(1);
        ^
parser.y:214:2: note: please include the header <stdlib.h> or explicitly provide a declaration for 'exit'
parser.y:224:10: error: implicit declaration of function 'strtoul' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        value = strtoul(hex, NULL, 16);
                ^
In file included from y.tab.c:460:
/usr/include/stdlib.h:112:3: error: conflicting types for 'strtoul'
         strtoul(const char * __restrict, char ** __restrict, int);
         ^
parser.y:224:10: note: previous implicit declaration is here
        value = strtoul(hex, NULL, 16);
                ^
3 errors generated.
*** [parser.o] Error code 1
>Fix:
--- yacc.diff begins here ---
Index: sysutils/uhidd/files/patch-uhidd-parser.y
===================================================================
RCS file: sysutils/uhidd/files/patch-uhidd-parser.y
diff -N sysutils/uhidd/files/patch-uhidd-parser.y
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ sysutils/uhidd/files/patch-uhidd-parser.y 24 May 2012 16:59:36 -0000
@@ -0,0 +1,10 @@
+--- uhidd/parser.y~
++++ uhidd/parser.y
+@@ -32,6 +32,7 @@
+ #include <err.h>
+ #include <errno.h>
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <string.h>
+ #include <syslog.h>
+
--- yacc.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

Edwin Groothuis-2
Synopsis: [patch] sysutils/uhidd: unbreak after yacc update in r235723

State-Changed-From-To: open->feedback
State-Changed-By: edwin
State-Changed-When: Thu May 24 17:20:12 UTC 2012
State-Changed-Why:
Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

http://www.freebsd.org/cgi/query-pr.cgi?pr=168311
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

Edwin Groothuis-2
In reply to this post by Jan Beich-2
The following reply was made to PR ports/168311; it has been noted by GNATS.

From: Edwin Groothuis <[hidden email]>
To: [hidden email]
Cc: [hidden email]
Subject: Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723
Date: Thu, 24 May 2012 17:20:09 UT

 Maintainer of sysutils/uhidd,
 
 Please note that PR ports/168311 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168311
 
 --
 Edwin Groothuis via the GNATS Auto Assign Tool
 [hidden email]
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

Jan Beich-2
In reply to this post by Jan Beich-2
The following reply was made to PR ports/168311; it has been noted by GNATS.

From: Jan Beich <[hidden email]>
To: [hidden email]
Cc:  
Subject: Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723
Date: Thu, 24 May 2012 17:29:54 +0000

 --=-=-=
 Content-Type: text/plain
 
 Oops, previous FreeBSD releases slipped my mind. And there is one more error.
 
 $ make CC=gcc46
 [...]
 y.tab.c:113:12: error: redundant redeclaration of 'yyparse' [-Werror=redundant-decls]
 parser.y:42:12: note: previous declaration of 'yyparse' was here
 cc1: all warnings being treated as errors
 *** [parser.o] Error code 1
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename=yacc.diff
 
 Index: sysutils/uhidd/Makefile
 ===================================================================
 RCS file: /a/.csup/ports/sysutils/uhidd/Makefile,v
 retrieving revision 1.6
 diff -u -p -r1.6 Makefile
 --- sysutils/uhidd/Makefile 3 Feb 2012 17:16:28 -0000 1.6
 +++ sysutils/uhidd/Makefile 24 May 2012 17:27:38 -0000
 @@ -40,6 +40,8 @@ MAKE_ENV+= DEBUG_FLAGS='${DEBUG_FLAGS}'
 
  .if ${OSVERSION} < 800069
  IGNORE= does not build with the old USB stack
 +.elif ${OSVERSION} > 1000012
 +EXTRA_PATCHES+= ${FILESDIR}/extra-patch-uhidd-parser.y
  .endif
 
  .if !(exists(${SYSDIR}/Makefile) || exists(${SRC_BASE}/sys/Makefile))
 Index: sysutils/uhidd/files/extra-patch-uhidd-parser.y
 ===================================================================
 RCS file: sysutils/uhidd/files/extra-patch-uhidd-parser.y
 diff -N sysutils/uhidd/files/extra-patch-uhidd-parser.y
 --- /dev/null 1 Jan 1970 00:00:00 -0000
 +++ sysutils/uhidd/files/extra-patch-uhidd-parser.y 24 May 2012 17:21:39 -0000
 @@ -0,0 +1,17 @@
 +--- uhidd/parser.y~
 ++++ uhidd/parser.y
 +@@ -32,13 +32,13 @@
 + #include <err.h>
 + #include <errno.h>
 + #include <stdio.h>
 ++#include <stdlib.h>
 + #include <string.h>
 + #include <syslog.h>
 +
 + #include "uhidd.h"
 +
 + extern int yylex(void);
 +-extern int yyparse(void);
 + extern int lineno;
 + extern FILE *yyin;
 +
 
 --=-=-=--
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

Kai Wang
In reply to this post by Jan Beich-2
The following reply was made to PR ports/168311; it has been noted by GNATS.

From: Kai Wang <[hidden email]>
To: [hidden email]
Cc:  
Subject: Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc
 update in r235723
Date: Sat, 26 May 2012 23:02:43 +0200

 Patch approved.
 
 Thanks,
 Kai
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

linimon
In reply to this post by Jan Beich-2
Synopsis: [patch] sysutils/uhidd: unbreak after yacc update in r235723

State-Changed-From-To: feedback->open
State-Changed-By: linimon
State-Changed-When: Sat May 26 21:22:01 UTC 2012
State-Changed-Why:
Maintainer approved.

http://www.freebsd.org/cgi/query-pr.cgi?pr=168311
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: ports/168311: [patch] sysutils/uhidd: unbreak after yacc update in r235723

Alex Kozlov-6
In reply to this post by Jan Beich-2
Synopsis: [patch] sysutils/uhidd: unbreak after yacc update in r235723

Responsible-Changed-From-To: freebsd-ports-bugs->ak
Responsible-Changed-By: ak
Responsible-Changed-When: Sun May 27 08:54:57 UTC 2012
Responsible-Changed-Why:
I'll take it.

http://www.freebsd.org/cgi/query-pr.cgi?pr=168311
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to "[hidden email]"