review: patch to restore VLAN kernel API in RELENG_6

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

review: patch to restore VLAN kernel API in RELENG_6

Gleb Smirnoff
--
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE

_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "[hidden email]"

VLAN_INPUT_TAG_NEW.diff (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: review: patch to restore VLAN kernel API in RELENG_6

delphij
Hi, Gleb,

On Fri, Jan 13, 2006 at 08:05:52PM +0300, Gleb Smirnoff wrote:

> Index: sys/dev/bge/if_bge.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
> retrieving revision 1.91.2.7
> diff -u -r1.91.2.7 if_bge.c
> --- sys/dev/bge/if_bge.c 13 Jan 2006 11:51:08 -0000 1.91.2.7
> +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000
> @@ -2862,7 +2862,7 @@
>   * attach that information to the packet.
>   */
>   if (have_tag) {
> - VLAN_INPUT_TAG(ifp, m, vlan_tag);
> + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);

What if "VLAN_INPUT_TAG_2" or something with numerical name?

Just my $0.02, though :-)

Cheers,
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: review: patch to restore VLAN kernel API in RELENG_6

Gleb Smirnoff
On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
X> Hi, Gleb,
X> > ===================================================================
X> > RCS file: /home/ncvs/src/sys/dev/bge/if_bge.c,v
X> > retrieving revision 1.91.2.7
X> > diff -u -r1.91.2.7 if_bge.c
X> > --- sys/dev/bge/if_bge.c 13 Jan 2006 11:51:08 -0000 1.91.2.7
X> > +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000
X> > @@ -2862,7 +2862,7 @@
X> >   * attach that information to the packet.
X> >   */
X> >   if (have_tag) {
X> > - VLAN_INPUT_TAG(ifp, m, vlan_tag);
X> > + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
X>
X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
X>
X> Just my $0.02, though :-)

I really don't care. :)

--
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: review: patch to restore VLAN kernel API in RELENG_6

delphij
On Fri, Jan 13, 2006 at 08:20:49PM +0300, Gleb Smirnoff wrote:

> On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
> X> > +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000
> X> > @@ -2862,7 +2862,7 @@
> X> >   * attach that information to the packet.
> X> >   */
> X> >   if (have_tag) {
> X> > - VLAN_INPUT_TAG(ifp, m, vlan_tag);
> X> > + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
> X>
> X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
> X>
> X> Just my $0.02, though :-)
>
> I really don't care. :)

Heh, my point was to make it possible to use the same name in
both drivers on RELENG_6 and 7.0, without having to call future
macros "foo_NEW_NG" or so =-)  Not really sure whether it is
conform to our tradition naming, though...

Cheers,
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: review: patch to restore VLAN kernel API in RELENG_6

Gleb Smirnoff
On Fri, Jan 13, 2006 at 05:52:12PM +0000, Xin LI wrote:
X> On Fri, Jan 13, 2006 at 08:20:49PM +0300, Gleb Smirnoff wrote:
X> > On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote:
X> > X> > +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000
X> > X> > @@ -2862,7 +2862,7 @@
X> > X> >   * attach that information to the packet.
X> > X> >   */
X> > X> >   if (have_tag) {
X> > X> > - VLAN_INPUT_TAG(ifp, m, vlan_tag);
X> > X> > + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag);
X> > X>
X> > X> What if "VLAN_INPUT_TAG_2" or something with numerical name?
X> > X>
X> > X> Just my $0.02, though :-)
X> >
X> > I really don't care. :)
X>
X> Heh, my point was to make it possible to use the same name in
X> both drivers on RELENG_6 and 7.0, without having to call future
X> macros "foo_NEW_NG" or so =-)  Not really sure whether it is
X> conform to our tradition naming, though...

The correct macro takes 3 arguments, and the old one took 4. So
we can't make a code compilable with correct macro on both systems
without breaking API - using same macro.

--
Totus tuus, Glebius.
GLEBIUS-RIPN GLEB-RIPE
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: review: patch to restore VLAN kernel API in RELENG_6

Vany Serezhkin
In reply to this post by Gleb Smirnoff
Gleb Smirnoff wrote:
thanks, this chunk compiles, but can you decride you doings in tommorow ?
Блин.
Я не настолько хорошо говорю по английски, чтоб понимать твои коментарии.
Тоесть все по диффу понятно, а нафига в целом ...полное безобразие.

вообщем английский я учить не перестану, но и проить объяснить тоже не
брошу =)

Если честно, то понятно только тем, кто прочёл магию kobj =)


--
Ivan. B. Serezhkin.
_______________________________________________
[hidden email] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-arch
To unsubscribe, send any mail to "[hidden email]"