sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Julian H. Stacey-3
.ctm_status src-cur 14077 .svn_revision 348842

===> sys/modules/sdio (all)
machine -> /usr/src/sys/amd64/include
x86 -> /usr/src/sys/x86/include
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/sdio/sdio_if.m -c
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/device_if.m -h
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/kern/bus_if.m -h
awk -f /usr/src/sys/tools/makeobjops.awk /usr/src/sys/dev/sdio/sdio_if.m -h
cc -target x86_64-unknown-freebsd13.0 --sysroot=/1s4/release/13.0-CURRENT/usr/obj/usr/src/amd64.amd64/tmp -B/1s4/release/13.0-CURRENT/usr/obj/usr/src/amd64.amd64/tmp/usr/bin  -O2 -pipe  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include     -MD  -MF.depend.sdiob.o -MTsdiob.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unus!
 ed-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member  -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c -o sdiob.o
/usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
      'opt_cam.h' file not found
#include "opt_cam.h"
         ^~~~~~~~~~~
1 error generated.
*** Error code 1

Stop.
bmake[5]: stopped in /usr/src/sys/modules/sdio
*** Error code 1

I assume some commiters fail to detect breakages as they don't
assert MODULES_WITH_WORLD="YES".  I saw similar twice in 2018-07
See disparity in supposedly current boxes, with:
        ls -l /boot/modules; ls -l /boot/kernel/kernel

Cheers,
Julian
--
Julian Stacey, Consultant Systems Engineer, BSD Linux Unix, Munich Aachen Kent
 Brexit ref. stole votes from 700,000 Brits in EU; 1.9 M young, more remainers
 had no vote; 1.3 M old mostly leavers died.  Advert lies paid by noses in the
 trough; some foreign funders fined. New referendum now! http://stolenvotes.uk
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Mark Linimon-2
On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> svn_revision 348842
[ ...]
> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
>       'opt_cam.h' file not found
> #include "opt_cam.h"
>          ^~~~~~~~~~~
> 1 error generated.

This is extremely unlikely to be r348842.  I would investigate r349025
instead.  (Committer Cc:ed.)

mcl
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Bjoern A. Zeeb-2
On 17 Jun 2019, at 10:37, Mark Linimon wrote:

> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
>> svn_revision 348842
> [ ...]
>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
>>       'opt_cam.h' file not found
>> #include "opt_cam.h"
>>          ^~~~~~~~~~~
>> 1 error generated.
>
> This is extremely unlikely to be r348842.  I would investigate r349025
> instead.  (Committer Cc:ed.)

Almost, more likely me.  I just had a look.  I am not exactly sure how
to reproduce this?

/bz
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Julian H. Stacey-3
Hi, Reference:
> From: "Bjoern A. Zeeb" <[hidden email]>
> Date: Mon, 17 Jun 2019 10:55:45 +0000

"Bjoern A. Zeeb" wrote:

> On 17 Jun 2019, at 10:37, Mark Linimon wrote:
>
> > On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> >> svn_revision 348842
> > [ ...]
> >> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> >>       'opt_cam.h' file not found
> >> #include "opt_cam.h"
> >>          ^~~~~~~~~~~
> >> 1 error generated.
> >
> > This is extremely unlikely to be r348842.  I would investigate r349025
> > instead.  (Committer Cc:ed.)
>
> Almost, more likely me.  I just had a look.  I am not exactly sure how
> to reproduce this?
>
> /bz

If I can help let me know.
My buildworld broke with 13.0-CURRENT
/usr/src .ctm_status src-cur 14077 .svn_revision 348842
I'm now running make install,
& can then compare my root include & libs with with a set installed
using DESTDIR=

I have a 2nd slower current box also building to 14077, I will then
take that on up to latest .ctm_status src-cur 14087 .svn_revision
349129 to see if problem clears.

Cheers,
Julian
--
Julian Stacey, Consultant Systems Engineer, BSD Linux Unix, Munich Aachen Kent
 Brexit ref. stole votes from 700,000 Brits in EU; 1.9 M young, more remainers
 had no vote; 1.3 M old mostly leavers died.  Advert lies paid by noses in the
 trough; some foreign funders fined. New referendum now! http://stolenvotes.uk
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Julian H. Stacey-3
In reply to this post by Mark Linimon-2
Mark Linimon wrote:

> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> > svn_revision 348842
> [ ...]
> > /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> >       'opt_cam.h' file not found
> > #include "opt_cam.h"
> >          ^~~~~~~~~~~
> > 1 error generated.
>
> This is extremely unlikely to be r348842.

Sorry, I just meant that's where my src/ was up to,
not that I suspected r348842

> I would investigate r349025
> instead.  (Committer Cc:ed.)

Thanks for looking, I found:
  https://svnweb.freebsd.org/base?view=revision&revision=349025
  Add opt_cam.h so we can build this outside of a kernel build.

My broken system only at 348842

My other slower current (also rebuilding to 348842), once finished,
I will take on & try with whatever is then latest, currently here that's
.svn_revision 349129 delivered by CTM with .ctm_status src-cur 14087

Cheers,
Julian
--
Julian Stacey, Consultant Systems Engineer, BSD Linux Unix, Munich Aachen Kent
 Brexit ref. stole votes from 700,000 Brits in EU; 1.9 M young, more remainers
 had no vote; 1.3 M old mostly leavers died.  Advert lies paid by noses in the
 trough; some foreign funders fined. New referendum now! http://stolenvotes.uk
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Cy Schubert-4
In reply to this post by Bjoern A. Zeeb-2
On June 17, 2019 3:55:45 AM PDT, "Bjoern A. Zeeb" <[hidden email]> wrote:

>On 17 Jun 2019, at 10:37, Mark Linimon wrote:
>
>> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
>>> svn_revision 348842
>> [ ...]
>>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
>>>       'opt_cam.h' file not found
>>> #include "opt_cam.h"
>>>          ^~~~~~~~~~~
>>> 1 error generated.
>>
>> This is extremely unlikely to be r348842.  I would investigate
>r349025
>> instead.  (Committer Cc:ed.)
>
>Almost, more likely me.  I just had a look.  I am not exactly sure how
>to reproduce this?
>
>/bz
>_______________________________________________
>[hidden email] mailing list
>https://lists.freebsd.org/mailman/listinfo/freebsd-current
>To unsubscribe, send any mail to
>"[hidden email]"

Could this be a possible race? I had an unrelated build failure on one of my machines, all with the same src tree. Simply restarting the failed buildworld resolved it. All my other machines had no such failure.


--
Pardon the typos and autocorrect, small keyboard in use.
Cheers,
Cy Schubert <[hidden email]>
FreeBSD UNIX: <[hidden email]> Web: http://www.FreeBSD.org

        The need of the many outweighs the greed of the few.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Warner Losh
On Mon, Jun 17, 2019, 8:06 AM Cy Schubert <[hidden email]> wrote:

> On June 17, 2019 3:55:45 AM PDT, "Bjoern A. Zeeb" <[hidden email]> wrote:
> >On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> >
> >> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> >>> svn_revision 348842
> >> [ ...]
> >>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> >>>       'opt_cam.h' file not found
> >>> #include "opt_cam.h"
> >>>          ^~~~~~~~~~~
> >>> 1 error generated.
> >>
> >> This is extremely unlikely to be r348842.  I would investigate
> >r349025
> >> instead.  (Committer Cc:ed.)
> >
> >Almost, more likely me.  I just had a look.  I am not exactly sure how
> >to reproduce this?
> >
> >/bz
> >_______________________________________________
> >[hidden email] mailing list
> >https://lists.freebsd.org/mailman/listinfo/freebsd-current
> >To unsubscribe, send any mail to
> >"[hidden email]"
>
> Could this be a possible race? I had an unrelated build failure on one of
> my machines, all with the same src tree. Simply restarting the failed
> buildworld resolved it. All my other machines had no such failure.
>

The thing I fixed wasn't a race per se, but just s missing dependency for
the stand alone build case. I fixed exactly the bug reported, and the
report came from a rev w/o my change. I think it is just that simple.

Warner

--

> Pardon the typos and autocorrect, small keyboard in use.
> Cheers,
> Cy Schubert <[hidden email]>
> FreeBSD UNIX: <[hidden email]> Web: http://www.FreeBSD.org
>
>         The need of the many outweighs the greed of the few.
> _______________________________________________
> [hidden email] mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "[hidden email]"
>
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Julian H. Stacey-3
In reply to this post by Julian H. Stacey-3
"Julian H. Stacey" wrote:

> "Bjoern A. Zeeb" wrote:
> > On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> >
> > > On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> > >> svn_revision 348842
> > > [ ...]
> > >> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> > >>       'opt_cam.h' file not found
> > >> #include "opt_cam.h"
> > >>          ^~~~~~~~~~~
> > >> 1 error generated.
> > >
> > > This is extremely unlikely to be r348842.  I would investigate r349025
> > > instead.  (Committer Cc:ed.)
> >
> > Almost, more likely me.  I just had a look.  I am not exactly sure how
> > to reproduce this?
> >
> > /bz
>
> If I can help let me know.
> My buildworld broke with 13.0-CURRENT
> /usr/src .ctm_status src-cur 14077 .svn_revision 348842
> I'm now running make install,
> & can then compare my root include & libs with with a set installed
> using DESTDIR=

I compiled, installed, compared.  
  BTW cd /usr/src; make delete  - only cleans libs & bins but does not
  clean other junk listed in ObsoleteFiles.inc not even with
  -DBATCH_DELETE_OLD_FILES or -DBATCH_DELETE_OLD_FILES=YES so manually purged,
I believe I have a clean system built from .ctm_status src-cur 14077
.svn_revision 348842 but /usr/src/sys/modules/sdio still fails,
so there was a commit of unbuildable code.

cd /usr/src ; find . -name opt_cam.h # tools/tools/vhba/opt_cam.h
cd /usr/include ; find . -name opt_cam.h # nothing


> I have a 2nd slower current box also building to 14077, I will then
> take that on up to latest .ctm_status src-cur 14087 .svn_revision
> 349129 to see if problem clears.

make buildworld blew on newer current, with a different bug:

cc  -O2 -pipe -I/usr/src/usr.bin/mkesdb_static -I/usr/src/usr.bin/mkesdb_static/../mkesdb  -I/usr/src/usr.bin/mkesdb_static/../../lib/libc/iconv  -g -MD  -MF.depend.lex.o -MTlex.o -std=gnu99  -Qunused-arguments   -I/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/include -c lex.c -o lex.o
/usr/src/usr.bin/mkesdb/lex.l:46:10: fatal error: 'yacc.h' file not found
#include "yacc.h"
         ^~~~~~~~
1 error generated.
*** Error code 1

Stop.
make[3]: stopped in /usr/src/usr.bin/mkesdb_static

A double waste of CPU & human time & power in a hot office.
Commit bits used to be suspended for un-buildable code. I'll boot stable.

Cheers,
Julian
--
Julian Stacey, Consultant Systems Engineer, BSD Linux Unix, Munich Aachen Kent
 Brexit ref. stole votes from 700,000 Brits in EU; 1.9 M young, more remainers
 had no vote; 1.3 M old mostly leavers died.  Advert lies paid by noses in the
 trough; some foreign funders fined. New referendum now! http://stolenvotes.uk
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Cy Schubert-4
On June 17, 2019 5:21:02 PM PDT, "Julian H. Stacey" <[hidden email]> wrote:

>"Julian H. Stacey" wrote:
>> "Bjoern A. Zeeb" wrote:
>> > On 17 Jun 2019, at 10:37, Mark Linimon wrote:
>> >
>> > > On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
>> > >> svn_revision 348842
>> > > [ ...]
>> > >> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal
>error:
>> > >>       'opt_cam.h' file not found
>> > >> #include "opt_cam.h"
>> > >>          ^~~~~~~~~~~
>> > >> 1 error generated.
>> > >
>> > > This is extremely unlikely to be r348842.  I would investigate
>r349025
>> > > instead.  (Committer Cc:ed.)
>> >
>> > Almost, more likely me.  I just had a look.  I am not exactly sure
>how
>> > to reproduce this?
>> >
>> > /bz
>>
>> If I can help let me know.
>> My buildworld broke with 13.0-CURRENT
>> /usr/src .ctm_status src-cur 14077 .svn_revision 348842
>> I'm now running make install,
>> & can then compare my root include & libs with with a set installed
>> using DESTDIR=
>
>I compiled, installed, compared.  
>  BTW cd /usr/src; make delete  - only cleans libs & bins but does not
>  clean other junk listed in ObsoleteFiles.inc not even with
>-DBATCH_DELETE_OLD_FILES or -DBATCH_DELETE_OLD_FILES=YES so manually
>purged,
>I believe I have a clean system built from .ctm_status src-cur 14077
>.svn_revision 348842 but /usr/src/sys/modules/sdio still fails,
>so there was a commit of unbuildable code.
>
>cd /usr/src ; find . -name opt_cam.h # tools/tools/vhba/opt_cam.h
>cd /usr/include ; find . -name opt_cam.h # nothing
>
>
>> I have a 2nd slower current box also building to 14077, I will then
>> take that on up to latest .ctm_status src-cur 14087 .svn_revision
>> 349129 to see if problem clears.
>
>make buildworld blew on newer current, with a different bug:
>
>cc  -O2 -pipe -I/usr/src/usr.bin/mkesdb_static
>-I/usr/src/usr.bin/mkesdb_static/../mkesdb
>-I/usr/src/usr.bin/mkesdb_static/../../lib/libc/iconv  -g -MD
>-MF.depend.lex.o -MTlex.o -std=gnu99  -Qunused-arguments  
>-I/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/include -c lex.c -o lex.o
>/usr/src/usr.bin/mkesdb/lex.l:46:10: fatal error: 'yacc.h' file not
>found
>#include "yacc.h"
>         ^~~~~~~~
>1 error generated.
>*** Error code 1
>
>Stop.
>make[3]: stopped in /usr/src/usr.bin/mkesdb_static
>
>A double waste of CPU & human time & power in a hot office.
>Commit bits used to be suspended for un-buildable code. I'll boot
>stable.
>
>Cheers,
>Julian

You're looking in the wrong place. Pardon the brevity, I'm doing this (ssh, copy/paste, email) on a phone.

Last login: Mon Jun 17 09:20:29 2019 from s0106788a207e2972.gv.shawcable.net
FreeBSD 13.0-CURRENT (PROD2) #362 r349135M: Mon Jun 17 05:10:26 PDT 2019

Access to, or unauthorized use of data on this computer by any person other
than authorized person(s) or owner(s) of an account is strictly prohibited
and may result in legal action against such person.

cwfw$ find /export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2 -name opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/hptrr/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/isp/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/hptiop/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/hpt27xx/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/arcmsr/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mvs/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/aacraid/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/siis/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/sym/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/vpo/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mps/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mrsas/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/iir/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/trm/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/sdio/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mpt/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/hptmv/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mfi/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mfi/mfip/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/twa/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/iscsi/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/pms/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/ata/atacore/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/esp/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/cxgbe/cxgbei/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/isci/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/ocs_fc/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/ahci/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mly/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/aic7xxx/ahd/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/aic7xxx/ahc/ahc_isa/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/aic7xxx/ahc/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/aic7xxx/ahc/ahc_pci/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/usb/umass/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/smartpqi/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/amr/amr_cam/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/hyperv/storvsc/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/nvme/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/cam/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/sdhci/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/aac/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/ctl/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/ciss/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/iscsi_initiator/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/virtio/scsi/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/firewire/sbp_targ/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/firewire/sbp/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/tws/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/mpr/opt_cam.h
/export/obj/opt/src/svn-current/amd64.amd64/sys/PROD2/modules/opt/src/svn-current/sys/modules/hptnr/opt_cam.h
cwfw$


--
Pardon the typos and autocorrect, small keyboard in use.
Cheers,
Cy Schubert <[hidden email]>
FreeBSD UNIX: <[hidden email]> Web: http://www.FreeBSD.org

        The need of the many outweighs the greed of the few.
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Ian Lepore-3
In reply to this post by Julian H. Stacey-3
On Tue, 2019-06-18 at 02:21 +0200, Julian H. Stacey wrote:

> "Julian H. Stacey" wrote:
> > "Bjoern A. Zeeb" wrote:
> > > On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> > >
> > > > On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey
> > > > wrote:
> > > > > svn_revision 348842
> > > >
> > > > [ ...]
> > > > > /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal
> > > > > error:
> > > > >       'opt_cam.h' file not found
> > > > > #include "opt_cam.h"
> > > > >          ^~~~~~~~~~~
> > > > > 1 error generated.
> > > >
> > > > This is extremely unlikely to be r348842.  I would investigate
> > > > r349025
> > > > instead.  (Committer Cc:ed.)
> > >
> > > Almost, more likely me.  I just had a look.  I am not exactly
> > > sure how
> > > to reproduce this?
> > >
> > > /bz
> >
> > If I can help let me know.
> > My buildworld broke with 13.0-CURRENT
> > /usr/src .ctm_status src-cur 14077 .svn_revision 348842
> > I'm now running make install,
> > & can then compare my root include & libs with with a set
> > installed
> > using DESTDIR=
>
> I compiled, installed, compared.  
>   BTW cd /usr/src; make delete  - only cleans libs & bins but does
> not
>   clean other junk listed in ObsoleteFiles.inc not even with
>   -DBATCH_DELETE_OLD_FILES or -DBATCH_DELETE_OLD_FILES=YES so
> manually purged,
> I believe I have a clean system built from .ctm_status src-cur 14077
> .svn_revision 348842 but /usr/src/sys/modules/sdio still fails,
> so there was a commit of unbuildable code.
>
> cd /usr/src ; find . -name opt_cam.h # tools/tools/vhba/opt_cam.h
> cd /usr/include ; find . -name opt_cam.h # nothing
>
>
> > I have a 2nd slower current box also building to 14077, I will then
> > take that on up to latest .ctm_status src-cur 14087 .svn_revision
> > 349129 to see if problem clears.
>
> make buildworld blew on newer current, with a different bug:
>
> cc  -O2 -pipe -I/usr/src/usr.bin/mkesdb_static
> -I/usr/src/usr.bin/mkesdb_static/../mkesdb  -
> I/usr/src/usr.bin/mkesdb_static/../../lib/libc/iconv  -g -MD  -
> MF.depend.lex.o -MTlex.o -std=gnu99  -Qunused-arguments   -
> I/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/include -c lex.c -o
> lex.o
> /usr/src/usr.bin/mkesdb/lex.l:46:10: fatal error: 'yacc.h' file not
> found
> #include "yacc.h"
>          ^~~~~~~~
> 1 error generated.
> *** Error code 1
>
> Stop.
> make[3]: stopped in /usr/src/usr.bin/mkesdb_static
>
> A double waste of CPU & human time & power in a hot office.
> Commit bits used to be suspended for un-buildable code. I'll boot
> stable.

Since you seem to be so focused on mean-spirited criticism of others,
I'm sure you'll understand when I ask...

Have you *seriosly* been using and building freebsd this long and you
don't know that an opt_*.h file is generated as part of the build and
exists only in the object directory, so that searching for it under
/usr/src or /usr/include would be... let's see, how did you put it?...
Oh yeah: A double waste of CPU & human time.

-- Ian

_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Julian H. Stacey-3
Hi, Reference:
> From: Ian Lepore <[hidden email]>
> Date: Mon, 17 Jun 2019 18:56:35 -0600

Ian Lepore wrote:

> On Tue, 2019-06-18 at 02:21 +0200, Julian H. Stacey wrote:
> > "Julian H. Stacey" wrote:
> > > "Bjoern A. Zeeb" wrote:
> > > > On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> > > >
> > > > > On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey
> > > > > wrote:
> > > > > > svn_revision 348842
> > > > >
> > > > > [ ...]
> > > > > > /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal
> > > > > > error:
> > > > > >       'opt_cam.h' file not found
> > > > > > #include "opt_cam.h"
> > > > > >          ^~~~~~~~~~~
> > > > > > 1 error generated.
> > > > >
> > > > > This is extremely unlikely to be r348842.  I would investigate
> > > > > r349025
> > > > > instead.  (Committer Cc:ed.)
> > > >
> > > > Almost, more likely me.  I just had a look.  I am not exactly
> > > > sure how
> > > > to reproduce this?
> > > >
> > > > /bz
> > >
> > > If I can help let me know.
> > > My buildworld broke with 13.0-CURRENT
> > > /usr/src .ctm_status src-cur 14077 .svn_revision 348842
> > > I'm now running make install,
> > > & can then compare my root include & libs with with a set
> > > installed
> > > using DESTDIR=
> >
> > I compiled, installed, compared.  
> >   BTW cd /usr/src; make delete  - only cleans libs & bins but does
> > not
> >   clean other junk listed in ObsoleteFiles.inc not even with
> >   -DBATCH_DELETE_OLD_FILES or -DBATCH_DELETE_OLD_FILES=YES so
> > manually purged,
> > I believe I have a clean system built from .ctm_status src-cur 14077
> > .svn_revision 348842 but /usr/src/sys/modules/sdio still fails,
> > so there was a commit of unbuildable code.
> >
> > cd /usr/src ; find . -name opt_cam.h # tools/tools/vhba/opt_cam.h
> > cd /usr/include ; find . -name opt_cam.h # nothing
> >
> >
> > > I have a 2nd slower current box also building to 14077, I will then
> > > take that on up to latest .ctm_status src-cur 14087 .svn_revision
> > > 349129 to see if problem clears.
> >
> > make buildworld blew on newer current, with a different bug:
> >
> > cc  -O2 -pipe -I/usr/src/usr.bin/mkesdb_static
> > -I/usr/src/usr.bin/mkesdb_static/../mkesdb  -
> > I/usr/src/usr.bin/mkesdb_static/../../lib/libc/iconv  -g -MD  -
> > MF.depend.lex.o -MTlex.o -std=gnu99  -Qunused-arguments   -
> > I/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/include -c lex.c -o
> > lex.o
> > /usr/src/usr.bin/mkesdb/lex.l:46:10: fatal error: 'yacc.h' file not
> > found
> > #include "yacc.h"
> >          ^~~~~~~~
> > 1 error generated.
> > *** Error code 1
> >
> > Stop.
> > make[3]: stopped in /usr/src/usr.bin/mkesdb_static
> >
> > A double waste of CPU & human time & power in a hot office.
> > Commit bits used to be suspended for un-buildable code. I'll boot
> > stable.
>
> Since you seem to be so focused on mean-spirited criticism of others,
> I'm sure you'll understand when I ask...
>
> Have you *seriosly* been using and building freebsd this long and you
> don't know that an opt_*.h file is generated as part of the build and
> exists only in the object directory, so that searching for it under
> /usr/src or /usr/include would be... let's see, how did you put it?...
> Oh yeah: A double waste of CPU & human time.

Personal noise is irrelevant.

Facts:
Unchecked commits broken make buildworld twice,
Time was wasted by bad commits.  
My time ran out.
Current does not benefit from commits that break buildworld.
I (like a friend before) must switch to stable to avoid breakage.

Time was, ~25 years back, when FreeBSD commiters who screwed
the build were awarded a conical hat & took a one week holiday. A
mild rebuke for wasting people's time, & a short refreshing
break to go smell fresh air. No not coffee, but fresh air.

Cheers,
Julian
--
Julian Stacey, Consultant Systems Engineer, BSD Linux Unix, Munich Aachen Kent
 Brexit ref. stole votes from 700,000 Brits in EU; 1.9 M young, more remainers
 had no vote; 1.3 M old mostly leavers died.  Advert lies paid by noses in the
 trough; some foreign funders fined. New referendum now! http://stolenvotes.uk
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Bryan Drewery-6
On 6/17/19 6:46 PM, Julian H. Stacey wrote:

> Hi, Reference:
>> From: Ian Lepore <[hidden email]>
>> Date: Mon, 17 Jun 2019 18:56:35 -0600
>
> Ian Lepore wrote:
>> On Tue, 2019-06-18 at 02:21 +0200, Julian H. Stacey wrote:
>>> "Julian H. Stacey" wrote:
>>>> "Bjoern A. Zeeb" wrote:
>>>>> On 17 Jun 2019, at 10:37, Mark Linimon wrote:
>>>>>
>>>>>> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey
>>>>>> wrote:
>>>>>>> svn_revision 348842
>>>>>>
>>>>>> [ ...]
>>>>>>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal
>>>>>>> error:
>>>>>>>       'opt_cam.h' file not found
>>>>>>> #include "opt_cam.h"
>>>>>>>          ^~~~~~~~~~~
>>>>>>> 1 error generated.
>>>>>>
>>>>>> This is extremely unlikely to be r348842.  I would investigate
>>>>>> r349025
>>>>>> instead.  (Committer Cc:ed.)
>>>>>
>>>>> Almost, more likely me.  I just had a look.  I am not exactly
>>>>> sure how
>>>>> to reproduce this?
>>>>>
>>>>> /bz
>>>>
>>>> If I can help let me know.
>>>> My buildworld broke with 13.0-CURRENT
>>>> /usr/src .ctm_status src-cur 14077 .svn_revision 348842
>>>> I'm now running make install,
>>>> & can then compare my root include & libs with with a set
>>>> installed
>>>> using DESTDIR=
>>>
>>> I compiled, installed, compared.  
>>>   BTW cd /usr/src; make delete  - only cleans libs & bins but does
>>> not
>>>   clean other junk listed in ObsoleteFiles.inc not even with
>>>   -DBATCH_DELETE_OLD_FILES or -DBATCH_DELETE_OLD_FILES=YES so
>>> manually purged,
>>> I believe I have a clean system built from .ctm_status src-cur 14077
>>> .svn_revision 348842 but /usr/src/sys/modules/sdio still fails,
>>> so there was a commit of unbuildable code.
>>>
>>> cd /usr/src ; find . -name opt_cam.h # tools/tools/vhba/opt_cam.h
>>> cd /usr/include ; find . -name opt_cam.h # nothing
>>>
>>>
>>>> I have a 2nd slower current box also building to 14077, I will then
>>>> take that on up to latest .ctm_status src-cur 14087 .svn_revision
>>>> 349129 to see if problem clears.
>>>
>>> make buildworld blew on newer current, with a different bug:
>>>
>>> cc  -O2 -pipe -I/usr/src/usr.bin/mkesdb_static
>>> -I/usr/src/usr.bin/mkesdb_static/../mkesdb  -
>>> I/usr/src/usr.bin/mkesdb_static/../../lib/libc/iconv  -g -MD  -
>>> MF.depend.lex.o -MTlex.o -std=gnu99  -Qunused-arguments   -
>>> I/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/include -c lex.c -o
>>> lex.o
>>> /usr/src/usr.bin/mkesdb/lex.l:46:10: fatal error: 'yacc.h' file not
>>> found
>>> #include "yacc.h"
>>>          ^~~~~~~~
>>> 1 error generated.
>>> *** Error code 1
>>>
>>> Stop.
>>> make[3]: stopped in /usr/src/usr.bin/mkesdb_static
>>>
>>> A double waste of CPU & human time & power in a hot office.
>>> Commit bits used to be suspended for un-buildable code. I'll boot
>>> stable.
>>
>> Since you seem to be so focused on mean-spirited criticism of others,
>> I'm sure you'll understand when I ask...
>>
>> Have you *seriosly* been using and building freebsd this long and you
>> don't know that an opt_*.h file is generated as part of the build and
>> exists only in the object directory, so that searching for it under
>> /usr/src or /usr/include would be... let's see, how did you put it?...
>> Oh yeah: A double waste of CPU & human time.
>
> Personal noise is irrelevant.
>
> Facts:
> Unchecked commits broken make buildworld twice,
> Time was wasted by bad commits.  
> My time ran out.
> Current does not benefit from commits that break buildworld.
> I (like a friend before) must switch to stable to avoid breakage.
>
> Time was, ~25 years back, when FreeBSD commiters who screwed
> the build were awarded a conical hat & took a one week holiday. A
> mild rebuke for wasting people's time, & a short refreshing
> break to go smell fresh air. No not coffee, but fresh air.
>
> Cheers,
> Julian
>
As the committer who broke yacc.h I'm sorry. I understand the
frustration. I too get frustrated by build breakage from others and even
myself. I appreciate the cc's here. I did test this particular change
with 1. clean build 2. -DNO_CLEAN 3. CLEANDIR=clean + -DNO_CLEAN (to
really rebuild everything but reuse the .depend files). And similar
pattern with META_MODE. And a cross-build of powerpc.powerpc64 to
capture some gcc deps and ensure cross-build was running the right
binaries. I missed not using -j though, that's a really odd case I'll
never test frankly.
Worse my build environment had MK_TESTS=no in it so I missed some other
bugs.
What I didn't test: buildkernel, install*, universe, ports (the last 2
will likely bite me still).
It's pretty common for all of us to forget to test installworld and ports.
Again this brings up the need for a real build test suite that can be
used pre-commit.


--
Regards,
Bryan Drewery


signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Scott Long-2
In reply to this post by Julian H. Stacey-3


> On Jun 17, 2019, at 7:46 PM, Julian H. Stacey <[hidden email]> wrote:
>
>>>
>>> Stop.
>>> make[3]: stopped in /usr/src/usr.bin/mkesdb_static
>>>
>>> A double waste of CPU & human time & power in a hot office.
>>> Commit bits used to be suspended for un-buildable code. I'll boot
>>> stable.
>>
>> Since you seem to be so focused on mean-spirited criticism of others,
>> I'm sure you'll understand when I ask...
>>
>> Have you *seriosly* been using and building freebsd this long and you
>> don't know that an opt_*.h file is generated as part of the build and
>> exists only in the object directory, so that searching for it under
>> /usr/src or /usr/include would be... let's see, how did you put it?...
>> Oh yeah: A double waste of CPU & human time.
>
> Personal noise is irrelevant.
>
> Facts:
> Unchecked commits broken make buildworld twice,
> Time was wasted by bad commits.  
> My time ran out.
> Current does not benefit from commits that break buildworld.
> I (like a friend before) must switch to stable to avoid breakage.
>
> Time was, ~25 years back, when FreeBSD commiters who screwed
> the build were awarded a conical hat & took a one week holiday. A
> mild rebuke for wasting people's time, & a short refreshing
> break to go smell fresh air. No not coffee, but fresh air.

I’ve been following FreeBSD since 1992, before it was even called
FreeBSD, and I was reflecting on the “old days” recently.  You know
what?  The old days sucked; I hold no romance for them.  There was
rampant passive-aggressive hostility, toxicity and shaming was
accepted and encouraged, and the community was pretty much an
insular and exclusionary clique. Mistakes were to be feared, not
learned from.  Any mistake was equated with a personal moral failing.
Yeah, good technical work was done, but at the expense of quickly
alienating and driving away many good people who didn’t want to
put up with all of that bullshit.

There’s no denying that it’s frustrating when a bug is introduced,
especially when it causes lost time and productivity.  Passively
accusing people of being lazy or incompetent (see your “Unchecked
commits” comment) doesn’t help fix that though.  If anything, it burns
out and drives away the people who are in the best position to fix the
problems. It doesn’t make the community or the code better in the
long term, even if you think that it’s motivating people in the short
term.

Please take your conical hat somewhere else and do something
productive and positive with it, I don’t want the toxicity in my
FreeBSD community anymore.

Thanks,
Scott



_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"
Reply | Threaded
Open this post in threaded view
|

Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found

Warner Losh
On Fri, Jun 21, 2019, 7:44 AM Scott Long <[hidden email]> wrote:

>
>
> > On Jun 17, 2019, at 7:46 PM, Julian H. Stacey <[hidden email]> wrote:
> >
> >>>
> >>> Stop.
> >>> make[3]: stopped in /usr/src/usr.bin/mkesdb_static
> >>>
> >>> A double waste of CPU & human time & power in a hot office.
> >>> Commit bits used to be suspended for un-buildable code. I'll boot
> >>> stable.
> >>
> >> Since you seem to be so focused on mean-spirited criticism of others,
> >> I'm sure you'll understand when I ask...
> >>
> >> Have you *seriosly* been using and building freebsd this long and you
> >> don't know that an opt_*.h file is generated as part of the build and
> >> exists only in the object directory, so that searching for it under
> >> /usr/src or /usr/include would be... let's see, how did you put it?...
> >> Oh yeah: A double waste of CPU & human time.
> >
> > Personal noise is irrelevant.
> >
> > Facts:
> > Unchecked commits broken make buildworld twice,
> > Time was wasted by bad commits.
> > My time ran out.
> > Current does not benefit from commits that break buildworld.
> > I (like a friend before) must switch to stable to avoid breakage.
> >
> > Time was, ~25 years back, when FreeBSD commiters who screwed
> > the build were awarded a conical hat & took a one week holiday. A
> > mild rebuke for wasting people's time, & a short refreshing
> > break to go smell fresh air. No not coffee, but fresh air.
>
> I’ve been following FreeBSD since 1992, before it was even called
> FreeBSD, and I was reflecting on the “old days” recently.  You know
> what?  The old days sucked; I hold no romance for them.  There was
> rampant passive-aggressive hostility, toxicity and shaming was
> accepted and encouraged, and the community was pretty much an
> insular and exclusionary clique. Mistakes were to be feared, not
> learned from.  Any mistake was equated with a personal moral failing.
> Yeah, good technical work was done, but at the expense of quickly
> alienating and driving away many good people who didn’t want to
> put up with all of that bullshit.
>
> There’s no denying that it’s frustrating when a bug is introduced,
> especially when it causes lost time and productivity.  Passively
> accusing people of being lazy or incompetent (see your “Unchecked
> commits” comment) doesn’t help fix that though.  If anything, it burns
> out and drives away the people who are in the best position to fix the
> problems. It doesn’t make the community or the code better in the
> long term, even if you think that it’s motivating people in the short
> term.
>
> Please take your conical hat somewhere else and do something
> productive and positive with it, I don’t want the toxicity in my
> FreeBSD community anymore.
>

Amen.

Warner

Thanks,
> Scott
>
>
>
> _______________________________________________
> [hidden email] mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "[hidden email]"
>
_______________________________________________
[hidden email] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "[hidden email]"